1252122 - count_only on buglist.cgi returns weird page with errors

Status: NEW

(bugzilla.mozilla.org :: Search, defect)

Description

[Axel Hecht [:Pike]]

I used this param for a regular search, as in https://bugzilla.mozilla.org/buglist.cgi?j_top=OR&o5=isnotempty&f1=OP&o3=casesubstring&list_id=12872890&v3=%20%2F%20&resolution=---&o2=equals&f4=CP&query_format=advanced&f3=component&f2=product&f5=cf_locale&v2=Mozilla%20Localizations&count_only=1, which returns a funny error-state page.

Main content is/was:

Bugzilla has suffered an internal error:

Can't use string ("996") as an ARRAY ref while "strict refs" in use

Which is funny, 'cause the result is actually in the error message.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1252122_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8725077 [details] [diff] [review]
1252122_1.patch

Review of attachment 8725077 [details] [diff] [review]:
-----------------------------------------------------------------

this changes the result from
> { "bug_count" : "14" }
to
> { "bug_count" : [ "14" ] }
which is bad.

this also doesn't fix the buglist.cgi crash:
> Can't use string ("14") as an ARRAY ref while "strict refs" in use at /opt/bugzilla/htdocs/1252122/buglist.cgi line 822

count_only is an api-only query, and it isn't clear what it should do when called from buglist.cgi.  we can't exactly show the result as a bug list.
imho buglist.cgi should strip count_only from the params it passes to Bugzilla::Search.

Comment 3

[Axel Hecht [:Pike]]

Is there a recommended way to get to the count of "This result was limited to 500 bugs." queries? There's limit=0 to get the full list, but that's dangerous if you fall into a trap that returns all bugs ;-) Alternatively, redo the query in a report, I guess? Maybe that's a feature request?

Comment 4

[Master ? [:masterquestionable]]

    [ Quote Axel Hecht @ CE 2016-03-01 15:30:50 UTC:
https://bugzilla.mozilla.org/show_bug.cgi?id=1252122#c3
    Is there a recommended way to get to the count of "This result was limited to 500 bugs." queries? ]
<^>    Like such: [ https://bugzilla.mozilla.org/rest/bug?count_only=1&f1=short_desc&o1=isnotempty ]?

    See also: https://bmo.readthedocs.io/en/latest/api/core/v1/bug.html#search-bugs