1252171 - TestNrSocket does not update last-used timestamps for TCP port mappings

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Comment 1

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1252171: Update last_used_ on TCP port mappings when they are used, similar to UDP. r?drno

Review commit: https://reviewboard.mozilla.org/r/37205/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37205/

Comment 2

[Eric Rescorla (:ekr)]

https://reviewboard.mozilla.org/r/37205/#review33735

::: media/mtransport/test_nr_socket.cpp:498
(Diff revision 1)
>      MOZ_ASSERT(port_mappings_.size() == 1);
> -    return port_mappings_.front()->external_socket_->read(buf, maxlen, len);
> +    int read = port_mappings_.front()->external_socket_->read(buf, maxlen, len);
> +    if (read > 0 && nat_->refresh_on_ingress_) {
> +      port_mappings_.front()->last_used_ = PR_IntervalNow();
> +    }
> +    return read;
>    }
>  }

Don't name this "read" because it's s libc symbol

::: media/mtransport/test_nr_socket.cpp:499
(Diff revision 1)
> -    return port_mappings_.front()->external_socket_->read(buf, maxlen, len);
> +    int read = port_mappings_.front()->external_socket_->read(buf, maxlen, len);
> +    if (read > 0 && nat_->refresh_on_ingress_) {
> +      port_mappings_.front()->last_used_ = PR_IntervalNow();
> +    }
> +    return read;
>    }
>  }
>  

Please don't name this "read", because that's a system primitive

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8724853 [details]
MozReview Request: Bug 1252171: Update last_used_ on TCP port mappings when they are used, similar to UDP. r?drno

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37205/diff/1-2/

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8724853 [details]
MozReview Request: Bug 1252171: Update last_used_ on TCP port mappings when they are used, similar to UDP. r?drno

https://reviewboard.mozilla.org/r/37205/#review34201

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61519a71531e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61519a71531e