1252212 - Bring some sanity to the RIL WorkerRun stuff

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

From my notes for bug 1072144:

  -- This is WorkerTaskRunnable.  It calls RunTask and returns its return
     value. This is only usd in ril code.  Of the three implementations: (a)
     RilWorker::UnregisterConsumerTask::RunTask does not use aCx and does not
     throw.  (b) RilSocketIO::ReceiveTask::RunTask calls
     RilSocket::ReceiveSocketData which calls
     RilSocketConsumer::ReceiveSocketData.  That's a pure virtual method and in
     practice only implemented by RilConsumer, which calls Receive.  This will
     do JSAPI stuff that can throw and will happily return true, leaving
     dangling exceptions.  XXXbz: This seems very broken.  Note that
     ReceiveSocketData is a void method, so it couldn't report an error even if
     it wanted to.  khuey says we don't care, just suppress things or something;
     worksforme.  (c) RilWorker::RegisterConsumerTask::RunTask calls
     ConnectWorkerToRIL which can both report pending exceptions itself and
     leave them on the JSContext, in both cases returning failure which gets
     turned into a false return from RunTask.  So this stuff is OK as long as we
     report exceptions in PostRun, which none of this stuff overrides.

This bug is about fixing that XXX comment.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the RIL WorkerRun implemetations not leave exceptions on the JSContext

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc2e892cf79d

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc2e892cf79d