Closed Bug 1252216 Opened 5 years ago Closed 5 years ago
Push extension configuration is vulnerable to CSRF
Push extension's configuration page lacks CSRF protection. This means that somebody can lure Bugzilla admins on a page containing the following code: > <img src="https://bugzilla-dev.allizom.org/page.cgi?id=push_config.html&save=1&global.enabled=Disabled&global.log_purge=0&Aha.enabled=Disabled&Aha.account_domain=&Aha.account_realm=&Aha.username=&Aha.password=&File.enabled=Enabled&File.filename=../show_bug.cgi&ReviewBoard.enabled=Disabled&ReviewBoard.product=&ReviewBoard.component=&ReviewBoard.version=&ReviewBoard.group=&ReviewBoard.cc=&TCL.enabled=Disabled&TCL.tcl_user=&TCL.sftp_host=&TCL.sftp_port=&TCL.sftp_user=&TCL.sftp_pass=&TCL.sftp_remote_path="> This will successfully change configuration parameters of the Push extension, and in this particular case disable almost everything. I didn't spend much time to investigate abuse potential here, in particular what the security group setting for ReviewBoard is doing. The link used above demonstrates one issue however: by setting File.filename parameter one can override files, even if they aren't located inside Bugzilla's data directory. I didn't bother figuring out whether one can somehow control the data being written to these files, but it allows adding data to a CGI file meaning that this could turn into a code execution vulnerability.
- Added csrf token checking for configuration UI - Added relative path check for File.pm filenames
Forgot to call delete_token()
(In reply to Wladimir Palant from comment #0) > ... but it allows adding data to a CGI file > meaning that this could turn into a code execution vulnerability. It is bad that paths weren't checked, but you'd have to find another location to abuse -- only data is writable by the httpd process. "Could turn into" would require code changes because the permissions are enforced by bugzilla code. Amusingly, if anyone were to use this extension on Windows, the check would be completely meaningless because paths don't start with /.
Attachment #8724985 - Flags: review?(dylan) → review+
To ssh://email@example.com/webtools/bmo/bugzilla.git 4d95649..e5b9aa6 master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Summary: Push extension configuration is vulnerable to CSRF and potentially code execution → Push extension configuration is vulnerable to CSRF
(In reply to Dylan William Hardison [:dylan] from comment #3) > It is bad that paths weren't checked, but you'd have to find another > location to abuse -- only data is writable by the httpd process. "Could turn > into" would require code changes because the permissions are enforced by > bugzilla code. Sure, I could only judge my test installation where this location looked writable. The other obvious victim would be "params" file of course - it's located inside the data directory and yet being executed (running inside Safe but probably able to do damage regardless). Or the template cache - it's located outside the data directory but I suspect that it must be writable.
dkl: could you take a stab at a security rating on this bug? What could be done to the Push extension, what damage would that cause to the installation?
sec-moderate based on feedback from dkl.
Flags: sec-bounty? → sec-bounty+
You need to log in before you can comment on or make changes to this bug.