1252242 - Fix Taskcluster names for firefox-ui-functional tests

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin (:whimboo) from bug 1237550 comment #12)
> Actually there is a mistake in the landed patch. I'm using firefox-ui as
> name of the test jobs which would not scale. This should have been
> firefox-ui-functional instead. I noticed that while trying to update the
> trychooser web page and thinking about other fx ui test types. I will come
> up with a follow-up patch.

mozreview only allows a single mozreview per person and bug, so a new bug has to be filed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: MozReview Request: Bug 1252242 - Fix Taskcluster names for firefox-ui-functional tests. r=ahal

Review commit: https://reviewboard.mozilla.org/r/37235/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37235/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Something went wrong here. The decision task has not created a single firefox-ui-test task. I'm investigating.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Greg, I would need your help here. Not sure why but the decision task hasn't been created tasks for the renamed firefox-ui-functional tests. I definitely changed all the instances of it, I even cross-checked with bug 1252242 where we initially added the feature. I cannot see why we are failing here. :S Thanks!

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8724924 [details]
MozReview Request: Bug 1252242 - Fix Taskcluster names for firefox-ui-functional tests. r=ahal

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37235/diff/1-2/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I was able to figure out the problem. I simply missed to change two names in base_job_flags.yml which actually include our tests. New try push should pass now.

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8724924 [details]
MozReview Request: Bug 1252242 - Fix Taskcluster names for firefox-ui-functional tests. r=ahal

https://reviewboard.mozilla.org/r/37235/#review33929

Lgtm!

Comment 7

[Greg Arndt [:garndt]]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> I was able to figure out the problem. I simply missed to change two names in
> base_job_flags.yml which actually include our tests. New try push should
> pass now.

Awesome!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f9ad3563417

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3f9ad3563417