Closed Bug 1252301 Opened 4 years ago Closed 4 years ago

Allow CONFIGURE_SUBST_FILES to be installed like GENERATED_FILES

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file)

This will help us get rid of at least gfx/cairo/cario/src/Makefile.in. Since CONFIGURE_SUBST_FILES aren't actually GeneratedFiles, we skip the normal logic that adds to the _no_skip['export'] list. Fixing this here also helps out in bug 1242632, but this is much easier to add a test case.
Blocks: 1252304
We need to consider CONFIGURE_SUBST_FILES as generated files when
processing FinalTargetFiles and related variables. Additionally, we have
to make sure that we actually recurse into such directories during the
export phase.

Review commit: https://reviewboard.mozilla.org/r/37271/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37271/
Attachment #8725014 - Flags: review?(mh+mozilla)
Attachment #8725014 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8725014 [details]
MozReview Request: Bug 1252301 - allow installing CONFIGURE_SUBST_FILES; r?glandium

https://reviewboard.mozilla.org/r/37271/#review34033
https://hg.mozilla.org/mozilla-central/rev/89a8eebdcdab
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.