1252384 - Remove nsICertTree.isHostPortOverride()

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

The last use of the method was removed in the changes for Bug 825583.

As such, the IDL definition and the implementation at https://hg.mozilla.org/mozilla-central/annotate/5e5b76d86634/security/manager/ssl/nsCertTree.cpp#l863 can now be removed.

Comment 1

[:Cykesiopka]

I forgot that there is a possibility that some add-on is using isHostPortOverride() for whatever reason, but I don't have access to the addons MXR so I can't say for for sure that it is unused.
Still, the method is IMO of low value and should be removed regardless.

This pseudocode might work as a workaround:
> function isHostPortOverride(index) {
>   let cert = nsICertTree.getCert(index);
>   return nsICertOverrideService.isCertUsedForOverrides(cert, ...) > 0;
> }

Comment 2

[:Cykesiopka]

Attachment: MozReview Request: Bug 1252384 - Remove nsICertTree.isHostPortOverride().

It is unused since the changes in Bug 825583 landed.

Review commit: https://reviewboard.mozilla.org/r/44573/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44573/

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8738547 [details]
MozReview Request: Bug 1252384 - Remove nsICertTree.isHostPortOverride().

https://reviewboard.mozilla.org/r/44573/#review41445

Looks like only 2 addons use it: the Firefox OS simulator (which I think only does so because it packages up everything in each desktop platform's build for some reason) and an addon called "Key Manager" for which the most recent version of Firefox that works is 24, so I think we're safe in removing this.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

cc mkaply so he's aware we're removing this.

Comment 5

[:Cykesiopka]

Thanks for the review!

(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> Looks like only 2 addons use it: the Firefox OS simulator (which I think
> only does so because it packages up everything in each desktop platform's
> build for some reason) and an addon called "Key Manager" for which the most
> recent version of Firefox that works is 24, so I think we're safe in
> removing this.
Cool, thanks for checking.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c630efea2a3f4f2d6052e0d10590440b5b62d1cb

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed5e2650d6a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ed5e2650d6a