Closed
Bug 1252414
Opened 8 years ago
Closed 8 years ago
handle lost context for webgl2 ClearBufferXXX function
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: posidron, Assigned: jerry)
References
Details
(Keywords: crash, csectype-nullptr, Whiteboard: [fuzzblocker][gfx-noted])
Attachments
(3 files, 2 obsolete files)
11.32 KB,
text/plain
|
Details | |
2.94 KB,
patch
|
jgilbert
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
2.91 KB,
patch
|
jerry
:
review+
|
Details | Diff | Splinter Review |
I can not reproduce this crash with a single test-case but happens on a regular basis.
Reporter | ||
Comment 1•8 years ago
|
||
Peter, can you get somebody to look at the stack or see if they can reproduce?
Flags: needinfo?(howareyou322)
Comment 3•8 years ago
|
||
Christoph, where did you get the call stack? Is it from treeherder?
Flags: needinfo?(cdiehl)
Reporter | ||
Comment 4•8 years ago
|
||
My current quarterly goal is to fuzz WebGL2. I got it from our fuzzing cluster.
Flags: needinfo?(cdiehl)
Updated•8 years ago
|
Whiteboard: [fuzzblocker] → [fuzzblocker][gfx-noted]
Comment 5•8 years ago
|
||
By running webgl2 conformance test, I had reproduced a crash in my local by using rr. But I had trouble to find the symbol for the build, check how to find the match symbol.
Flags: needinfo?(howareyou322) → needinfo?(bas)
Reporter | ||
Comment 7•8 years ago
|
||
Is there any update. I know this bug has no testcase but it is blocking fuzzing WebGL2 in further detail.
Comment 8•8 years ago
|
||
Can someone take a look at fixing this? This really blocks WebGL2 fuzzing efforts.
Flags: needinfo?(howareyou322)
Assignee | ||
Comment 9•8 years ago
|
||
I will take a look.
Assignee: nobody → hshih
Flags: needinfo?(howareyou322)
Assignee | ||
Comment 10•8 years ago
|
||
Christoph, I'm not familiar with fuzzing test and fuzzing cluster. Is it at try server? And how can I trigger the test locally or at server side?
Status: NEW → ASSIGNED
Flags: needinfo?(cdiehl)
Reporter | ||
Comment 11•8 years ago
|
||
Clearing n-i, cause we talked about this on IRC. Jerry has received a copy of Framboise and the WebGL2 module.
Flags: needinfo?(cdiehl)
Assignee | ||
Comment 12•8 years ago
|
||
Hi Christoph, I still have problem for fuzzy testing. When the testing starts, I got a lot of error message. I don't know that these message is abnormal or not. The log are in: https://pastebin.mozilla.org/8863969
Flags: needinfo?(cdiehl)
Assignee | ||
Comment 13•8 years ago
|
||
In the crash stack, it shows that the webgl context is already lost. And then we call ClearBufferfv() in js. Normally, it's fine to call any gl function even though the device is lost. This is a bug that we don't check the device status in some gl api. I need to check all gl functions. It might take some times.
Flags: needinfo?(cdiehl)
Assignee | ||
Comment 14•8 years ago
|
||
Attachment #8731583 -
Flags: review?(jgilbert)
Assignee | ||
Updated•8 years ago
|
Summary: WebGL2: crash [@mozilla::gl::GLContext::IsDestroyed] → handle lost context for webgl2 ClearBufferXXX function
Updated•8 years ago
|
Attachment #8731583 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 15•8 years ago
|
||
try link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=15a296d686d6 Please land the attachment 8731583 [details] [diff] [review] to m-c
Keywords: checkin-needed
Comment 16•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c8ed5ea5eaf
Keywords: checkin-needed
Comment 17•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8c8ed5ea5eaf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Hi Jerry, Jeff, should we consider uplifting these fixes to Aurora 47 as status-firefox47 is affected? Please let me know.
Flags: needinfo?(jgilbert)
Flags: needinfo?(hshih)
Comment 19•8 years ago
|
||
Comment on attachment 8731583 [details] [diff] [review] handle lost_context for webgl ClearBuffer*. v1 Approval Request Comment [Feature/regressing bug #]: webgl2 [User impact if declined]: Bad behavior is uncommon cases. [Describe test coverage new/current, TreeHerder]: In non-local webgl conformance tests. [Risks and why]: none [String/UUID change made/needed]: none
Flags: needinfo?(jgilbert)
Flags: needinfo?(hshih)
Attachment #8731583 -
Flags: approval-mozilla-aurora?
Comment on attachment 8731583 [details] [diff] [review] handle lost_context for webgl ClearBuffer*. v1 Crash fix, Aurora47+
Attachment #8731583 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 21•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/e8c5bba77ee5
Assignee | ||
Comment 22•8 years ago
|
||
Attachment #8736564 -
Flags: review?(jgilbert)
Comment 23•8 years ago
|
||
Comment on attachment 8736564 [details] [diff] [review] test case for webgl2 ClearBufferXXX(). v1 Review of attachment 8736564 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/test/webgl-mochitest/test_webgl_fuzzy_pattern.html @@ +34,5 @@ > + var canvas = document.createElement('canvas'); > + canvas.id = 'webglCanvas'; > + canvas.height = 512; > + canvas.width = 512; > + document.body.appendChild(canvas); Don't bother with anything but creating the canvas here, since it's not relevant to the below.
Attachment #8736564 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 24•8 years ago
|
||
Attachment #8737056 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Attachment #8736564 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8737056 -
Attachment is obsolete: true
Assignee | ||
Comment 26•8 years ago
|
||
try for attachment 8738944 [details] [diff] [review] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c58ae61969a5
Assignee | ||
Comment 27•8 years ago
|
||
Please land the attachment 8738944 [details] [diff] [review] to m-c. test cast for this bug.
Comment 28•8 years ago
|
||
bugherder landing |
https://hg.mozilla.org/integration/mozilla-inbound/rev/36c71d816690
Keywords: checkin-needed
Comment 29•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/36c71d816690
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•