Closed Bug 1252498 Opened 4 years ago Closed 4 years ago

Baldr: add Wasm object behind pref, default off

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(1 file)

This patch adds javascript.options.wasm, defaulting to false on all platforms.  When enabled, this pref adds a 'Wasm' global property (similar to Math, JSON and SIMD).  The Wasm object currently has one static method named instantiateModule which is just a renaming of the previous wasmEval TestingFunction.  We already know we're going to replace Wasm.instantiateModule with an async method + sync constructor, but its inclusion now allows interop with the v8 experimental impl and running the same demos on both (once the binary formats converge).
Confirmed is not present by default in browser build.
Attachment #8725296 - Flags: review?(jorendorff)
Comment on attachment 8725296 [details] [diff] [review]
wasm-obj-with-pref

Review of attachment 8725296 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

::: js/src/asmjs/Wasm.cpp
@@ +1381,5 @@
> +{
> +    MOZ_ASSERT(cx->runtime()->options().wasm());
> +
> +    CallArgs args = CallArgsFromVp(argc, vp);
> +    RootedObject callee(cx, &args.callee());

This variable is unused.

::: js/src/asmjs/Wasm.h
@@ +35,5 @@
>  HasCompilerSupport(ExclusiveContext* cx);
>  
> +// Return whether WebAssembly can be used at all on this platform.
> +bool
> +IsSupported(JSContext* cx);

I don't see a definition or use of this in this patch. (And the comment leaves me wondering what the difference is between this and HasCompilerSupport(), but I guess that is probably moot.)
Attachment #8725296 - Flags: review?(jorendorff) → review+
(In reply to Jason Orendorff [:jorendorff] from comment #2)
> I don't see a definition or use of this in this patch.

Oops, that's leftover from an intermediate state of the patch; it can be deleted.
https://hg.mozilla.org/mozilla-central/rev/6c8b2fbba88b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.