Closed
Bug 1252637
Opened 9 years ago
Closed 9 years ago
Uninstalling Firefox doesn't removing keychain information associated with Authentication
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
3.0
People
(Reporter: sleroux, Assigned: sleroux)
References
Details
Attachments
(1 file)
Turns out that anything we save to the Keychain doesn't get cleared whenever the user uninstalls Firefox. What can happen is that if a user setups a passcode/Touch ID, if they were to remove the app and reinstall at a future date, that same passcode will be set. We should probably clear out this information on first launch.
Assignee | ||
Updated•9 years ago
|
tracking-fxios:
--- → ?
Comment 1•9 years ago
|
||
We follow this pattern for FxA credentials:
https://github.com/mozilla/firefox-ios/blob/f5d3245cbae23f99e91f6d4074f805cb32b2e987/Providers/Profile.swift#L217
Assignee | ||
Comment 2•9 years ago
|
||
Awesome thanks for the pointer!
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8725810 -
Flags: review?(rnewman)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Comment 4•9 years ago
|
||
Comment on attachment 8725810 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1591
If this works, LGTM!
Attachment #8725810 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 5•9 years ago
|
||
master a515dbdd6fdc292c0e3b4c607f898c7e3ada55bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
tracking-fxios:
? → ---
Resolution: --- → FIXED
Whiteboard: [needsuplift]
Target Milestone: --- → 3.0
Assignee | ||
Comment 6•9 years ago
|
||
v3.x 9471c8dde001d62fa74fcd7b292e3334a29eb905
status-fxios-v3.0:
--- → fixed
Whiteboard: [needsuplift]
Comment 7•9 years ago
|
||
Verifying as fixed on 3.0(6)
Status: RESOLVED → VERIFIED
status-fxios-v2.0:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•