1252653 - Intermittent incremental-state.js | incremental-state.js:48:1 Error: Assertion failed: got "mark", expected "none" (code 3, args "--baseline-eager")

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=7678647&repo=fx-team

Comment 1

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* fx-team: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-6: 4
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1252653&startday=2016-02-29&endday=2016-03-06&tree=all

Comment 2

[Intermittent Failures Robot]

8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 2
* fx-team: 2
* mozilla-aurora: 1

Platform breakdown:
* osx-10-6: 7
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1252653&startday=2016-03-07&endday=2016-03-13&tree=all

Comment 3

[Jon Coppeard (:jonco)]

This fails slightly less than 1 in 100 runs on macosx locally.  I haven't seen a failure in several thousand runs on linux.

Comment 4

[Jon Coppeard (:jonco)]

Attachment: bug1252653-incremental-state-test

So this is just a test issue.  gczeal() with only one argument will set the zeal frequency to the default - 100 allocations.  This can trigger additional GCs that the test is not expecting.  I don't know why the failure is non-deterministic though... oh, gcstate() is allocating a string to return.  And our while loop to wait for the end of finalization depends on thread scheduling.

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 8731257 [details] [diff] [review]
bug1252653-incremental-state-test

Review of attachment 8731257 [details] [diff] [review]:
-----------------------------------------------------------------

Subtle! Good find!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2370836d2861

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2370836d2861

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7d547d913a2e