Open Bug 1252660 Opened 8 years ago Updated 5 months ago
Move main-thread `Push
Manager` implementation into C++
The main-thread `PushManager` is currently implemented in `Push.js`, whereas the worker thread implementation lives in `PushManager.cpp`. This is the only JS-implemented interface in Push; `PushSubscription` and `PushMessageData` are already in C++. There's a fair bit of duplication between the two (especially after bug 1247685), and I've noticed some inconsistencies around error reporting. As it stands, any WebIDL changes require updating both files. If the main-thread implementation were rewritten in C++, I think it would be easier to maintain. OTOH, if we don't anticipate many changes to `PushManager`, maybe we can leave it be. Something to think about, though.
Type: defect → task
You need to log in before you can comment on or make changes to this bug.