1252660 - Move main-thread `PushManager` implementation into C++

Status: NEW

(Core :: DOM: Push Subscriptions, task, P5)

Description

[Lina Butler [:lina]]

The main-thread `PushManager` is currently implemented in `Push.js`, whereas the worker thread implementation lives in `PushManager.cpp`. This is the only JS-implemented interface in Push; `PushSubscription` and `PushMessageData` are already in C++.

There's a fair bit of duplication between the two (especially after bug 1247685), and I've noticed some inconsistencies around error reporting. As it stands, any WebIDL changes require updating both files.

If the main-thread implementation were rewritten in C++, I think it would be easier to maintain. OTOH, if we don't anticipate many changes to `PushManager`, maybe we can leave it be. Something to think about, though.

Comment 1

[Jens Stutte [:jstutte]]

It seems the JS part lives now in Push.jsm but the hybrid implementation is still there, IIUC. Not sure if this is really something to worry about, though?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

The situation does seem the same as when this bug was filed, yes.

I would say this doesn't need to currently be a direct priority, but that we should keep the bug around as a means of expressing when having only a single code path would make other bugs simpler (ex: bug 1497430 which depends on this bug) or where other bugs are only really feasible when fixing this bug.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Note: Push.js is now Push.sys.mjs