1252699 - Build error on ubuntu 15.04 with an arm-hf toolchain

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[[:fabrice] Fabrice Desré]

When building with the docker image at https://github.com/makotokato/dockerfile-gecko-armhf-cross we fail to link:

../../build/unix/gold/ld: error: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_iSACFix/Unified_c_webrtc_modules1.o: multiple definition of 'WebRtcIsacfix_kSinTab2'
../../build/unix/gold/ld: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_isac_neon/transform_neon.o: previous definition here
../../build/unix/gold/ld: error: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_iSACFix/Unified_c_webrtc_modules1.o: multiple definition of 'WebRtcIsacfix_kSinTab1'
../../build/unix/gold/ld: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_isac_neon/transform_neon.o: previous definition here
../../build/unix/gold/ld: error: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_iSACFix/Unified_c_webrtc_modules1.o: multiple definition of 'WebRtcIsacfix_kCosTab1'
../../build/unix/gold/ld: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_isac_neon/transform_neon.o: previous definition here

Comment 1

[[:fabrice] Fabrice Desré]

So it seems like we are going into https://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/transform_tables.c#21

Looks like the WEBRTC_DETECT_ARM_NEON and/or WEBRTC_ARCH_ARM_NEON feature detection is broken?

Comment 2

[Mike Hommey [:glandium]]

Those tables are *also* defined in media/webrtc/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/transform_neon.S. That would be the problem.

Comment 3

[Mike Hommey [:glandium]]

The question becomes... why does this not affect our android builds?

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Mike Hommey [:glandium] from comment #3)
> The question becomes... why does this not affect our android builds?

Because of http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/build/common.gypi#323 I believe.

Comment 5

[[:fabrice] Fabrice Desré]

I mean, why aren't we detecting neon everywhere?

Comment 6

[Mike Hommey [:glandium]]

Oh, we're forcing arm_neon to 0 in build/gyp.mozbuild.

Comment 7

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

Review commit: https://reviewboard.mozilla.org/r/37509/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37509/

Comment 8

[Mike Hommey [:glandium]]

Fabrice, can you check the patch works for you?

Comment 9

[[:fabrice] Fabrice Desré]

(In reply to Mike Hommey [:glandium] from comment #8)
> Fabrice, can you check the patch works for you?

Yes, this works.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

https://reviewboard.mozilla.org/r/37509/#review34131

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cfe0596c5e9

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 1198458
[User impact if declined]: Cannot compile Firefox for non-Android/b2g armhf architectures
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: NPOTB. I guess it's too late to make it to the 45 release :( At least getting it in 46 would be nice.
[String/UUID change made/needed]: None

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cfe0596c5e9

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

It is too late for 45 but we can take a patch for esr45.1
Could be a ride along if we do a 45.0.1

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39c568d733dc

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39c568d733dc

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

cf comment #12

Comment 18

[Mike Hommey [:glandium]]

Why am I receiving mails that this is tracked for esr38? (and can we get it on esr45?)

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

Simplify the life of some people, taking it.

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-esr45/rev/5f2ca769a064