Closed Bug 1252699 Opened 4 years ago Closed 4 years ago

Build error on ubuntu 15.04 with an arm-hf toolchain

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 + wontfix
firefox46 --- fixed
firefox47 --- fixed
firefox-esr45 46+ fixed

People

(Reporter: fabrice, Assigned: glandium)

Details

Attachments

(1 file)

When building with the docker image at https://github.com/makotokato/dockerfile-gecko-armhf-cross we fail to link:

../../build/unix/gold/ld: error: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_iSACFix/Unified_c_webrtc_modules1.o: multiple definition of 'WebRtcIsacfix_kSinTab2'
../../build/unix/gold/ld: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_isac_neon/transform_neon.o: previous definition here
../../build/unix/gold/ld: error: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_iSACFix/Unified_c_webrtc_modules1.o: multiple definition of 'WebRtcIsacfix_kSinTab1'
../../build/unix/gold/ld: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_isac_neon/transform_neon.o: previous definition here
../../build/unix/gold/ld: error: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_iSACFix/Unified_c_webrtc_modules1.o: multiple definition of 'WebRtcIsacfix_kCosTab1'
../../build/unix/gold/ld: /mozilla/obj-gecko/toolkit/library/../../media/webrtc/trunk/webrtc/modules/modules_isac_neon/transform_neon.o: previous definition here
Summary: Build error on ubuntu 15.04 with an arm-hg toolchain → Build error on ubuntu 15.04 with an arm-hf toolchain
So it seems like we are going into https://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/transform_tables.c#21

Looks like the WEBRTC_DETECT_ARM_NEON and/or WEBRTC_ARCH_ARM_NEON feature detection is broken?
Those tables are *also* defined in media/webrtc/trunk/webrtc/modules/audio_coding/codecs/isac/fix/source/transform_neon.S. That would be the problem.
The question becomes... why does this not affect our android builds?
(In reply to Mike Hommey [:glandium] from comment #3)
> The question becomes... why does this not affect our android builds?

Because of http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/build/common.gypi#323 I believe.
I mean, why aren't we detecting neon everywhere?
Oh, we're forcing arm_neon to 0 in build/gyp.mozbuild.
Fabrice, can you check the patch works for you?
(In reply to Mike Hommey [:glandium] from comment #8)
> Fabrice, can you check the patch works for you?

Yes, this works.
Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

https://reviewboard.mozilla.org/r/37509/#review34131
Attachment #8725496 - Flags: review?(rjesup) → review+
Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 1198458
[User impact if declined]: Cannot compile Firefox for non-Android/b2g armhf architectures
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: NPOTB. I guess it's too late to make it to the 45 release :( At least getting it in 46 would be nice.
[String/UUID change made/needed]: None
Attachment #8725496 - Flags: approval-mozilla-beta?
Attachment #8725496 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/2cfe0596c5e9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

It is too late for 45 but we can take a patch for esr45.1
Could be a ride along if we do a 45.0.1
Attachment #8725496 - Flags: approval-mozilla-beta?
Attachment #8725496 - Flags: approval-mozilla-beta-
Attachment #8725496 - Flags: approval-mozilla-aurora?
Attachment #8725496 - Flags: approval-mozilla-aurora+
Assignee: nobody → mh+mozilla
Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

cf comment #12
Attachment #8725496 - Flags: approval-mozilla-esr45?
Why am I receiving mails that this is tracked for esr38? (and can we get it on esr45?)
Comment on attachment 8725496 [details]
MozReview Request: Bug 1252699 - Set WEBRTC_DETECT_ARM_NEON when optional neon is requested

Simplify the life of some people, taking it.
Attachment #8725496 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
You need to log in before you can comment on or make changes to this bug.