Closed Bug 125272 Opened 24 years ago Closed 24 years ago

Stop(_h_) while search in progress

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
All
Windows 95
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file, 1 obsolete file)

Fixed patch to swap S and h access keys
1.22 KB, patch
naving
: review+
sspitzer
: superreview+
asa
: approval+
Details | Diff | Splinter Review
Using Build ID: 2002021203 While searching is in progress the stop label is ugly.
Attached patch Proposed Patch (obsolete) — — Splinter Review
This changes the search messages accesskey to m, so that the search/stop button accesskey can be changed to S.
Has jennifer approved this change?
mnemonic "m" can't be used because "More" button is already using it. "h" can be used though (Searc_h_ for messages in:"). I'll update spec. Thanks.
Sorry for using the wrong access key last time :-(
Attachment #69258 - Attachment is obsolete: true
Comment on attachment 69444 [details] [diff] [review] Fixed patch to swap S and h access keys r=naving I think these changes are not needed. -<!ENTITY abSearchDialogTitle.label "Advanced Directory Search"> \ No newline at end of file +<!ENTITY abSearchDialogTitle.label "Advanced Directory Search">
Attachment #69444 - Flags: review+
naving@netscape.com: indeed it isn't essential however someone decided that text files end in a newline, so we try to follow that.
Assignee: naving → neil
I was never saying that you don't put a new line at the end of the file. I know we need that.
:-) that's all that change does
Comment on attachment 69444 [details] [diff] [review] Fixed patch to swap S and h access keys sr=sspitzer
Attachment #69444 - Flags: superreview+
hopefully we can land this UI polish during 1.0
Keywords: patch, review
Hardware: PC → All
Target Milestone: --- → mozilla1.0
Attachment #69444 - Flags: approval+
Comment on attachment 69444 [details] [diff] [review] Fixed patch to swap S and h access keys a=asa (on behalf of drivers) for checkin to the 1.0 trunk
fix checked in for Neil. Note to QA: the accesskey for the label will not work until the "Search UI: mnemonics needed" bug is fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
OK using: Mar11 commercial trunk - win98 mar12 commercial trunk - linux rh6.2
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: