Stop(_h_) while search in progress

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla1.0
All
Windows 95

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.22 KB, patch
Navin Gupta
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
Using Build ID: 2002021203
While searching is in progress the stop label is ugly.
(Assignee)

Comment 1

16 years ago
Created attachment 69258 [details] [diff] [review]
Proposed Patch

This changes the search messages accesskey to m, so that the search/stop button
accesskey can be changed to S.

Comment 2

16 years ago
Has jennifer approved this change?

Comment 3

16 years ago
mnemonic "m" can't be used because "More" button is already using it. "h" can be 
used though (Searc_h_ for messages in:").

I'll update spec. Thanks.

(Assignee)

Comment 4

16 years ago
Created attachment 69444 [details] [diff] [review]
Fixed patch to swap S and h access keys

Sorry for using the wrong access key last time :-(
Attachment #69258 - Attachment is obsolete: true

Comment 5

16 years ago
Comment on attachment 69444 [details] [diff] [review]
Fixed patch to swap S and h access keys

r=naving I think
these changes are 
not needed.

-<!ENTITY abSearchDialogTitle.label   "Advanced Directory Search">
\ No newline at end of file
+<!ENTITY abSearchDialogTitle.label   "Advanced Directory Search">
Attachment #69444 - Flags: review+

Comment 6

16 years ago
naving@netscape.com: indeed it isn't essential however someone decided that 
text files end in a newline, so we try to follow that.
Assignee: naving → neil

Comment 7

16 years ago
I was never saying that you don't put a new line at the end of the file. 
I know we need that. 

Comment 8

16 years ago
:-) that's all that change does
Comment on attachment 69444 [details] [diff] [review]
Fixed patch to swap S and h access keys

sr=sspitzer
Attachment #69444 - Flags: superreview+
hopefully we can land this UI polish during 1.0
Keywords: patch, review
Hardware: PC → All
Target Milestone: --- → mozilla1.0

Updated

16 years ago
Attachment #69444 - Flags: approval+

Comment 11

16 years ago
Comment on attachment 69444 [details] [diff] [review]
Fixed patch to swap S and h access keys

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

16 years ago
fix checked in for Neil.  

Note to QA: the accesskey for the label will not work until the "Search UI:
mnemonics needed" bug is fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 13

16 years ago
OK using:
Mar11 commercial trunk - win98
mar12 commercial trunk - linux rh6.2
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

Updated

10 years ago
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.