Closed Bug 1252777 Opened 8 years ago Closed 8 years ago

Disable passive ICE TCP sockets until bug 1179345 lands

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: drno, Assigned: drno)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

We should disable support for passive ICE TCP candidates until bug 1179345 lands and gives us support for listening and accepting TCP connections under e10s.

The assumption here is that the major benefit from ICE TCP comes from Firefox running behind a NAT and/or packet filter, which won't incoming TCP connections pass through any way, but the active ICE TCP support in Firefox will still allow to connect to end points with passive ICE TCP support on public IP addresses.
Attachment #8725596 - Flags: review?(docfaraday)
Attachment #8725596 - Flags: review?(docfaraday)
Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

https://reviewboard.mozilla.org/r/37571/#review34181

::: media/mtransport/third_party/nICEr/src/ice/ice_component.c:447
(Diff revision 1)
> +        /* TODO drno: re-enable this after bug 1179345 has landed!
>          if ((r=nr_ice_component_create_tcp_host_candidate(ctx, component, &addrs[i].addr,
>            TCP_TYPE_PASSIVE, backlog, 0, lufrag, pwd, &isock_psv)))
>            ABORT(r);
> +        */

How soon is this going to be? Unless very soon, I would prefer to have a flag passed down, or maybe even forgive failures here.
Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37571/diff/1-2/
Attachment #8725596 - Attachment description: MozReview Request: Bug 1252777: disable ICE TCP passice candidates → MozReview Request: Bug 1252777: skip over passive ICE TCP candiate failure creation. r=bwc
Attachment #8725596 - Flags: review?(docfaraday)
Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37571/diff/2-3/
Attachment #8725596 - Attachment description: MozReview Request: Bug 1252777: skip over passive ICE TCP candiate failure creation. r=bwc → MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc
Attachment #8725596 - Flags: review?(docfaraday) → review+
Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

https://reviewboard.mozilla.org/r/37571/#review34505
Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37571/diff/3-4/
https://hg.mozilla.org/mozilla-central/rev/d2e86ab855bd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.