1252777 - Disable passive ICE TCP sockets until bug 1179345 lands

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Nils Ohlmeier [:drno]]

We should disable support for passive ICE TCP candidates until bug 1179345 lands and gives us support for listening and accepting TCP connections under e10s.

The assumption here is that the major benefit from ICE TCP comes from Firefox running behind a NAT and/or packet filter, which won't incoming TCP connections pass through any way, but the active ICE TCP support in Firefox will still allow to connect to end points with passive ICE TCP support on public IP addresses.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review commit: https://reviewboard.mozilla.org/r/37571/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37571/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

https://reviewboard.mozilla.org/r/37571/#review34181

::: media/mtransport/third_party/nICEr/src/ice/ice_component.c:447
(Diff revision 1)
> +        /* TODO drno: re-enable this after bug 1179345 has landed!
>          if ((r=nr_ice_component_create_tcp_host_candidate(ctx, component, &addrs[i].addr,
>            TCP_TYPE_PASSIVE, backlog, 0, lufrag, pwd, &isock_psv)))
>            ABORT(r);
> +        */

How soon is this going to be? Unless very soon, I would prefer to have a flag passed down, or maybe even forgive failures here.

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37571/diff/1-2/

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37571/diff/2-3/

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

https://reviewboard.mozilla.org/r/37571/#review34505

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 8725596 [details]
MozReview Request: Bug 1252777: skip over ICE TCP host candidate creation failures. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37571/diff/3-4/

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2e86ab855bd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d2e86ab855bd