Closed
Bug 1252787
Opened 9 years ago
Closed 9 years ago
Add HID profile to profile list in BluetoothProfileController if remote device is remote controller
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: lochang, Assigned: lochang)
References
Details
Attachments
(1 file, 4 obsolete files)
We should add the HID profile to the list when the remote device is remote controller. Then we can establish a connection to a remote controller.
|
||
Updated•9 years ago
|
Summary: [Bluetooth][HID] Add HID profile to the list if the device is remote controller → Add HID profile to profile list in BluetoothProfileController if remote device is remote controller
|
Assignee | |
Comment 1•9 years ago
|
||
Hi Shawn,
Would you like to review the patch? The patch is to add HID profile into the profile list if the remote device is remote controller.
Thanks
Attachment #8726609 -
Flags: review?(shuang)
Comment on attachment 8726609 [details] [diff] [review]
Bug 1252787 - Patch (v1) : Add HID profile to list if device is remote controller
Review of attachment 8726609 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bluetooth/common/BluetoothProfileController.cpp
@@ +210,5 @@
> + if ((isPeripheral && isRemoteControl)) {
> + if (hasRendering) {
> + AddProfile(BluetoothAvrcpManager::Get());
> + }
> + else {
nit: Move this line up. "} else {"
Attachment #8726609 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Ok, thanks for the reviewing.
Attachment #8726609 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8727275 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•9 years ago
|
||
Sorry, fixed the redundant tab.
Attachment #8729325 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•9 years ago
|
||
Add "r=shawnjohnjr" to the title name.
Attachment #8729330 -
Attachment is obsolete: true
Keywords: checkin-needed
Hi
Next time please make sure your title is as the same as your attachment description.
|
|
Assignee | |
Comment 10•9 years ago
|
||
(In reply to Shawn Huang [:shawnjohnjr] from comment #9)
> Hi
> Next time please make sure your title is as the same as your attachment
> description.
Ok, i will confirm that next time.
|
||
Comment 11•9 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•