1252893 - Memory panel doesn't look so hot when docked to the side

Status: NEW

(DevTools :: Memory, defect, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1222403#c21
https://bugzilla.mozilla.org/show_bug.cgi?id=1222403#c22

Comment 1

[johngraciliano]

In Firefox Nightly 47.0a1, when the memory tool is in a narrow area (as when dock to the side) if a snapshot is taken, the panel may show a horizontal scrollbar under the table.  This scrollbar only scrolls the tree (the cells) but not the header in the panel.
After reconsidering my suggested solution in https://bugzilla.mozilla.org/show_bug.cgi?id=1222403#c22
I change it to (this goes into memory.css):
  #heap-view{
    overflow-x: auto;
  }
  #heap-view > :-moz-any([data-state="snapshot-state-saved-census"],
                             [data-state="diffing-state-took-diff"]).heap-view-panel {
    min-width: 100ch;
  }
That way the scrollbar is only used when showing a table (snapshot or difference) and it makes more space for the name(s).  The messages that may otherwise show in the heap-view fit better in the narrow view without the scrollbar.

Comment 2

[johngraciliano]

The toolbar for the memory tool may need to be rearranged when the window is narrow.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

STR: open devtools, enable and select memory panel, dock devtools on right

ER: Usable

AR: Not usable

Comment 4

[johngraciliano]

Thanks again Nick, that should have been on the top.
...
I will add that when using the "Dominators" view, it is probably best to show the table on top of the diagram, instead of showing them side by side.  The snapshot tiles may remain on the side.