Closed Bug 1252905 Opened 4 years ago Closed 4 years ago

Don't invoke the interrupt callback while an exception is pending

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Right now we can do that in two places: when returning from jitcode (the two places are baseline and ion) to interp due to an exception being thrown.  Interrupt callback implementations can (and do!) spin the event loop, and doing that with a pending exception on the JSContext is a bad idea.
Comment on attachment 8725735 [details] [diff] [review]
Don't invoke the interrupt callback while an exception is pending

Review of attachment 8725735 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8725735 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/432cce28b337
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Depends on: 1375447
You need to log in before you can comment on or make changes to this bug.