1252905 - Don't invoke the interrupt callback while an exception is pending

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we can do that in two places: when returning from jitcode (the two places are baseline and ion) to interp due to an exception being thrown.  Interrupt callback implementations can (and do!) spin the event loop, and doing that with a pending exception on the JSContext is a bad idea.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't invoke the interrupt callback while an exception is pending

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8725735 [details] [diff] [review]
Don't invoke the interrupt callback while an exception is pending

Review of attachment 8725735 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/432cce28b337

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/432cce28b337