Closed Bug 1253011 Opened 7 years ago Closed 7 years ago

Remove Gingerbread Flash interfaces


(Firefox for Android Graveyard :: Plugins, defect)

45 Branch
Not set


(firefox48 fixed)

Firefox 48
Tracking Status
firefox48 --- fixed


(Reporter: snorp, Assigned: droeh)




(1 file, 1 obsolete file)

We're going to stop supporting Gingerbread, so we can rip out all of the Flash support code for that too.
Attached patch Proposed patchSplinter Review
I think this kills everything we safely can.
Attachment #8729674 - Flags: review?(snorp)
Comment on attachment 8729674 [details] [diff] [review]
Proposed patch

Review of attachment 8729674 [details] [diff] [review]:

We can also remove AndroidBridge::AddPluginView, the code that calls it in nsPluginInstanceOwner, and the java side of things in GeckoAppShell and friends.

::: dom/plugins/base/android/ANPBase.h
@@ -26,1 @@
>  void InitCanvasInterface(ANPCanvasInterfaceV0 *i);

Do we still need this? Hopefully not?
Attachment #8729674 - Flags: review?(snorp) → review-
Attached patch Proposed patch (updated) (obsolete) — Splinter Review
Alright, removed AndroidBridge::AddPluginView and all related code that I could find. I don't think the Canvas stuff can be killed off, though.
Attachment #8729674 - Attachment is obsolete: true
Attachment #8730983 - Flags: review?(snorp)
Comment on attachment 8730983 [details] [diff] [review]
Proposed patch (updated)

Review of attachment 8730983 [details] [diff] [review]:

Oops. I just realized we still need some of this stuff for full screen mode. I steered you wrong, sorry! Your original patch is probably about as good as we can do for now.
Attachment #8730983 - Flags: review?(snorp) → review-
Attachment #8729674 - Attachment is obsolete: false
Attachment #8729674 - Flags: review- → review+
Attachment #8730983 - Attachment is obsolete: true
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.