1253011 - Remove Gingerbread Flash interfaces

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We're going to stop supporting Gingerbread, so we can rip out all of the Flash support code for that too.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch

I think this kills everything we safely can.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8729674 [details] [diff] [review]
Proposed patch

Review of attachment 8729674 [details] [diff] [review]:
-----------------------------------------------------------------

We can also remove AndroidBridge::AddPluginView, the code that calls it in nsPluginInstanceOwner, and the java side of things in GeckoAppShell and friends.

::: dom/plugins/base/android/ANPBase.h
@@ -26,1 @@
>  void InitCanvasInterface(ANPCanvasInterfaceV0 *i);

Do we still need this? Hopefully not?

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch (updated)

Alright, removed AndroidBridge::AddPluginView and all related code that I could find. I don't think the Canvas stuff can be killed off, though.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8730983 [details] [diff] [review]
Proposed patch (updated)

Review of attachment 8730983 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. I just realized we still need some of this stuff for full screen mode. I steered you wrong, sorry! Your original patch is probably about as good as we can do for now.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/062f72657846

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/062f72657846