1253030 - remove dom mochitests for showModalDialog

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Tracy Walker [:tracy]]

remove test cases for showModalDialog in dom/tests/mochitest/bugs/

test_bug406375.html
test_bug437361.html
test_bug504862.html

Comment 1

[Tracy Walker [:tracy]]

Attachment: bug_1253030.patch

'hg remove' the three test files and deleted associated lines in mochitest.ini

Comment 2

[Tracy Walker [:tracy]]

I'll also post a patch for removing a few others. Or bundle them up all together?

dom/base/test/test_dialogArguments.html
dom/html/test/test_bug391777.html
dom/html/test/test_iframe_sandbox_modal.html

Comment 3

[Jim Mathies [:jimm]]

(In reply to Tracy Walker [:tracy] from comment #2)
> I'll also post a patch for removing a few others. Or bundle them up all
> together?
> 
> dom/base/test/test_dialogArguments.html
> dom/html/test/test_bug391777.html
> dom/html/test/test_iframe_sandbox_modal.html

Are these showModalDialog related?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Why remove those? It's not dead yet in non-e10s builds, is it?

Comment 5

[Jim Mathies [:jimm]]

(In reply to :Ms2ger from comment #4)
> Why remove those? It's not dead yet in non-e10s builds, is it?

According to the test status spreadsheet we want these removed.

https://docs.google.com/spreadsheets/d/10UeyRoiWV2HjkWwAU51HXyXAV7YLi4BjDm55mr5Xv6c/edit?pref=2&pli=1#gid=368835050

Also, see bug 981796. Blake is busy with e10s so he probably hasn't gotten to that bug yet. Based on the comments there we could remove this from nightly today. We've given people ample warning.

Comment 6

[Tracy Walker [:tracy]]

(In reply to Jim Mathies [:jimm] from comment #3) 
> > dom/base/test/test_dialogArguments.html
> > dom/html/test/test_bug391777.html
> > dom/html/test/test_iframe_sandbox_modal.html
> 
> Are these showModalDialog related?

Yes, those three are also marked "Remove" and comment showModalDialog in the test status spreadsheet.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c08d02caf56

Comment 8

[Masatoshi Kimura [:emk]]

(In reply to Tracy Walker [:tracy] from comment #6)
> (In reply to Jim Mathies [:jimm] from comment #3) 
> > > dom/base/test/test_dialogArguments.html
> > > dom/html/test/test_bug391777.html
> > > dom/html/test/test_iframe_sandbox_modal.html
> > 
> > Are these showModalDialog related?
> 
> Yes, those three are also marked "Remove" and comment showModalDialog in the
> test status spreadsheet.

How has this decision been made? Will Firefox 47 enable e10s everywhere? Otherwise I don't think it is correct to remove tests for a shipped feature.

Comment 9

[Masatoshi Kimura [:emk]]

Or showModalDialog itself should also be removed now.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c08d02caf56

Comment 11

[Tracy Walker [:tracy]]

(In reply to Masatoshi Kimura [:emk] from comment #9)
> Or showModalDialog itself should also be removed now.

That is being tracked in bug 981796.

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yes, so this bug should not land before bug 981796.

Comment 13

[Carsten Book [:Tomcat]]

 (In reply to :Ms2ger from comment #12)
> Yes, so this bug should not land before bug 981796.

backed out in https://hg.mozilla.org/mozilla-central/rev/e7319545eb38 from m-c

Comment 14

[Masatoshi Kimura [:emk]]

(In reply to :Ms2ger from comment #12)
> Yes, so this bug should not land before bug 981796.

Making it explicit.

Comment 15

[Andrew McCreight [:mccr8]]

Please don't remove DOM tests without review from a DOM peer.

Comment 16

[Tracy Walker [:tracy]]

Yes, my apologies. I was under the incorrect understanding that showModalDialog was already unsupported.  I'll leave it to DOM team to remove the associated test cases when showModalDialog is disabled.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Comment 18

[Andrew McCreight [:mccr8]]

These tests have been removed (though I see a few related files that are still around. I'll file a bug for that.)