Closed
Bug 1253032
Opened 8 years ago
Closed 8 years ago
Recent change to JSON::XS breaks some APIs
Categories
(bugzilla.mozilla.org :: API, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
Details
Attachments
(1 file)
|
622 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
https://metacpan.org/changes/distribution/JSON-XS#L9 "allow_nonref now affects booleans" which I think means it dies on them now. Previously they were considered refs. We need to use the allow_nonref option to prevent this error.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → webservice
Component: General → WebService
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: default-qa
Version: Production → unspecified
|
||
Comment 1•8 years ago
|
||
Which API methods are affected?
|
|
Assignee | |
Comment 2•8 years ago
|
||
valid_login currently.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Right, bmo returns a bare "true" or "false" but upstream doesn't. :-/
Assignee: webservice → nobody
Component: WebService → API
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production
|
|
Assignee | |
Comment 4•8 years ago
|
||
Assignee: nobody → dylan
Attachment #8726186 -
Flags: review?(dkl)
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8726186 [details] [diff] [review] 1253032_1.patch Review of attachment 8726186 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8726186 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 9744f3c..97e70cc master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•