1253076 - Artifact builds fail handling symbols files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Bisection led to f2990a314e23. Full output is:

 0:00.09 Running |mach artifact install|.
 0:00.09 /home/chris/m-c/mach artifact install
 0:00.43 Installing from remote pushhead f2990a314e2312d2f6bf4e5b4632083815f85f7d on mozilla-inbound
 0:00.43 Installing from https://queue.taskcluster.net/v1/task/GW_mftl-RfS2aCNQSvXT5w/artifacts/public%2Fbuild%2Ffirefox-47.0a1.en-US.linux-x86_64.common.tests.zip
 0:00.43 Installing from /home/chris/.mozbuild/package-frontend/9cca8a30ea8073e1-public%2Fbuild%2Ffirefox-47.0a1.en-US.linux-x86_64.common.tests.zip
 0:00.43 Installing from processed /home/chris/.mozbuild/package-frontend/9cca8a30ea8073e1-public%2Fbuild%2Ffirefox-47.0a1.en-US.linux-x86_64.common.tests.zip.processed.jar
 0:00.45 Not updating /home/chris/m-c/obj-art/dist/bin/BadCertServer
 0:00.46 Not updating /home/chris/m-c/obj-art/dist/bin/GenerateOCSPResponse
 0:00.47 Not updating /home/chris/m-c/obj-art/dist/bin/OCSPStaplingServer
 0:00.47 Not updating /home/chris/m-c/obj-art/dist/bin/certutil
 0:00.48 Not updating /home/chris/m-c/obj-art/dist/bin/fileid
 0:00.48 Not updating /home/chris/m-c/obj-art/dist/bin/pk12util
 0:00.49 Not updating /home/chris/m-c/obj-art/dist/bin/ssltunnel
 0:00.49 Not updating /home/chris/m-c/obj-art/dist/bin/xpcshell
 0:00.50 Not updating /home/chris/m-c/obj-art/dist/plugins/libnpctrltest.so
 0:00.50 Not updating /home/chris/m-c/obj-art/dist/plugins/libnpsecondtest.so
 0:00.50 Not updating /home/chris/m-c/obj-art/dist/plugins/libnpswftest.so
 0:00.50 Not updating /home/chris/m-c/obj-art/dist/plugins/libnptest.so
 0:00.51 Not updating /home/chris/m-c/obj-art/dist/plugins/libnptestjava.so
 0:00.51 Not updating /home/chris/m-c/obj-art/dist/plugins/libnpthirdtest.so
 0:00.51 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-clearkey/0.1/clearkey.info
 0:00.51 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-clearkey/0.1/libclearkey.so
 0:00.51 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-fake/1.0/fake.info
 0:00.51 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-fake/1.0/fake.voucher
 0:00.52 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-fake/1.0/libfake.so
 0:00.52 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-fakeopenh264/1.0/fakeopenh264.info
 0:00.52 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-fakeopenh264/1.0/fakeopenh264.voucher
 0:00.52 Not updating /home/chris/m-c/obj-art/dist/plugins/gmp-fakeopenh264/1.0/libfakeopenh264.so
 0:00.52 Installing from https://queue.taskcluster.net/v1/task/GW_mftl-RfS2aCNQSvXT5w/artifacts/public%2Fbuild%2Ffirefox-47.0a1.en-US.linux-x86_64.tar.bz2
 0:00.52 Installing from /home/chris/.mozbuild/package-frontend/aab429df147dc58b-public%2Fbuild%2Ffirefox-47.0a1.en-US.linux-x86_64.tar.bz2
 0:00.52 Installing from processed /home/chris/.mozbuild/package-frontend/aab429df147dc58b-public%2Fbuild%2Ffirefox-47.0a1.en-US.linux-x86_64.tar.bz2.processed.jar
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/libnss3.so
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/libnspr4.so
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/libplc4.so
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/gtk2/libmozgtk.so
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/updater
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/libsmime3.so
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/libmozgtk.so
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/plugin-container
 0:00.53 Not updating /home/chris/m-c/obj-art/dist/bin/libmozavutil.so
 0:00.54 Not updating /home/chris/m-c/obj-art/dist/bin/libnssckbi.so
 0:00.54 Not updating /home/chris/m-c/obj-art/dist/bin/libnssdbm3.so
 0:00.54 Not updating /home/chris/m-c/obj-art/dist/bin/gmp-clearkey/0.1/libclearkey.so
 0:00.54 Not updating /home/chris/m-c/obj-art/dist/bin/browser/components/libbrowsercomps.so
 0:00.54 Not updating /home/chris/m-c/obj-art/dist/bin/dependentlibs.list
 0:00.55 Not updating /home/chris/m-c/obj-art/dist/bin/libmozavcodec.so
 0:00.55 Not updating /home/chris/m-c/obj-art/dist/bin/liblgpllibs.so
 0:00.55 Not updating /home/chris/m-c/obj-art/dist/bin/libmozsqlite3.so
 0:00.56 Not updating /home/chris/m-c/obj-art/dist/bin/libsoftokn3.so
 0:00.56 Not updating /home/chris/m-c/obj-art/dist/bin/firefox-bin
 0:00.56 Not updating /home/chris/m-c/obj-art/dist/bin/firefox
 0:00.56 Not updating /home/chris/m-c/obj-art/dist/bin/libssl3.so
 0:00.56 Not updating /home/chris/m-c/obj-art/dist/bin/libnssutil3.so
 0:01.17 Not updating /home/chris/m-c/obj-art/dist/bin/libxul.so
 0:01.17 Not updating /home/chris/m-c/obj-art/dist/bin/libplds4.so
 0:01.18 Not updating /home/chris/m-c/obj-art/dist/bin/libfreebl3.so
 0:01.18 Not updating /home/chris/m-c/obj-art/dist/bin/crashreporter
 0:01.18 Not updating /home/chris/m-c/obj-art/dist/bin/webapprt-stub
 0:01.36 /usr/bin/make -f client.mk -s
 0:02.15 Adding client.mk options from /home/chris/m-c/mozconfig:
 0:02.15     AUTOCLOBBER=1
 0:02.15     export MOZ_AUTOMATION_PACKAGE=1
 0:02.15     export MOZ_AUTOMATION_PACKAGE_TESTS=1
 0:02.15     export MOZ_AUTOMATION_BUILD_SYMBOLS=1
 0:02.15     MOZ_OBJDIR=/home/chris/m-c/obj-art
 0:02.15     OBJDIR=/home/chris/m-c/obj-art
 0:02.15     FOUND_MOZCONFIG=/home/chris/m-c/mozconfig
 0:02.19 Build configuration changed. Regenerating backend.
 0:02.29 Reticulating splines...
 0:05.92 Traceback (most recent call last):
 0:05.92   File "config.status", line 991, in <module>
 0:05.92     config_status(**args)
 0:05.92   File "/home/chris/m-c/python/mozbuild/mozbuild/config_status.py", line 165, in config_status
 0:05.92     the_backend.consume(definitions)
 0:05.92   File "/home/chris/m-c/python/mozbuild/mozbuild/backend/base.py", line 126, in consume
 0:05.92     for obj in objs:
 0:05.92   File "/home/chris/m-c/python/mozbuild/mozbuild/frontend/emitter.py", line 176, in emit
 0:05.92     objs = list(self.emit_from_context(out))
 0:05.92   File "/home/chris/m-c/python/mozbuild/mozbuild/frontend/emitter.py", line 903, in emit_from_context
 0:05.92     for obj in self._handle_linkables(context, passthru):
 0:05.92   File "/home/chris/m-c/python/mozbuild/mozbuild/frontend/emitter.py", line 575, in _handle_linkables
 0:05.92     [symbols_file.full_path], lib.defines.get_defines())
 0:05.92 AttributeError: 'NoneType' object has no attribute 'get_defines'
 0:06.04 Makefile:124: recipe for target 'backend.FasterMake+RecursiveMakeBackend' failed
 0:06.04 make[2]: *** [backend.FasterMake+RecursiveMakeBackend] Error 1
 0:06.04 /home/chris/m-c/client.mk:398: recipe for target 'realbuild' failed
 0:06.04 make[1]: *** [realbuild] Error 2
 0:06.04 client.mk:171: recipe for target 'build' failed
 0:06.04 make: *** [build] Error 2
 0:06.08 0 compiler warnings present.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

I have a basic fix, I don't know what we should actually be doing here.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1253076 - Handle the case defines are not present to avoid artifact build bustage when processing symbols files. r=glandium

Review commit: https://reviewboard.mozilla.org/r/37699/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37699/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8725936 [details]
MozReview Request: Bug 1253076 - Handle the case defines are not present to avoid artifact build bustage when processing symbols files. r=glandium

https://reviewboard.mozilla.org/r/37699/#review34263

::: python/mozbuild/mozbuild/frontend/emitter.py:573
(Diff revision 1)
> +                    defines = None

() would be a better default.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/624b22ec6462

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/624b22ec6462