Closed Bug 1253123 Opened 8 years ago Closed 8 years ago

Remove some unused Chromium code

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

(Whiteboard: btpp-active)

Attachments

(4 files)

I'm going to try to remove some stuff that we don't use form the Chromium IPC import.
Whiteboard: btpp-active
Attachment #8726009 - Flags: review?(jld) → review+
Comment on attachment 8726010 [details] [diff] [review]
Remove ipc_sync_message

Review of attachment 8726010 [details] [diff] [review]:
-----------------------------------------------------------------

ipc/chromium/src/chrome/common/ipc_message.h has a `friend class SyncMessage`; it should be harmless, but might as well delete that too.
Attachment #8726010 - Flags: review?(jld) → review+
Comment on attachment 8726011 [details] [diff] [review]
Remove message_router

Review of attachment 8726011 [details] [diff] [review]:
-----------------------------------------------------------------

Those ChildThread methods do indeed seem dead.  Nice.
Attachment #8726011 - Flags: review?(jld) → review+
Attachment #8726013 - Flags: review?(jld) → review+
(In reply to Wes Kocher (:KWierso) from comment #8)
> I had to back this out along with everything else from this push for build
> bustage like
> https://treeherder.mozilla.org/logviewer.html#?job_id=24870637&repo=mozilla-
> inbound
> https://hg.mozilla.org/integration/mozilla-inbound/rev/444648c7d761

That looks like it's from a different bug.  This bug's patches should be okay on their own, but I'll push them to Try first.
Flags: needinfo?(wmccloskey) → needinfo?(jld)
You need to log in before you can comment on or make changes to this bug.