Closed
Bug 1253123
Opened 8 years ago
Closed 8 years ago
Remove some unused Chromium code
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
Details
(Whiteboard: btpp-active)
Attachments
(4 files)
10.89 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
30.79 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
7.66 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
19.61 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
I'm going to try to remove some stuff that we don't use form the Chromium IPC import.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8726009 -
Flags: review?(jld)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8726010 -
Flags: review?(jld)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8726011 -
Flags: review?(jld)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8726013 -
Flags: review?(jld)
Updated•8 years ago
|
Whiteboard: btpp-active
Updated•8 years ago
|
Attachment #8726009 -
Flags: review?(jld) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8726010 [details] [diff] [review] Remove ipc_sync_message Review of attachment 8726010 [details] [diff] [review]: ----------------------------------------------------------------- ipc/chromium/src/chrome/common/ipc_message.h has a `friend class SyncMessage`; it should be harmless, but might as well delete that too.
Attachment #8726010 -
Flags: review?(jld) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8726011 [details] [diff] [review] Remove message_router Review of attachment 8726011 [details] [diff] [review]: ----------------------------------------------------------------- Those ChildThread methods do indeed seem dead. Nice.
Attachment #8726011 -
Flags: review?(jld) → review+
Updated•8 years ago
|
Attachment #8726013 -
Flags: review?(jld) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c8278e8047e https://hg.mozilla.org/integration/mozilla-inbound/rev/d345149b2169 https://hg.mozilla.org/integration/mozilla-inbound/rev/f0dd577131c7
Comment 8•8 years ago
|
||
backout bugherder landing |
I had to back this out along with everything else from this push for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=24870637&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/444648c7d761
Flags: needinfo?(wmccloskey)
Comment 9•8 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #8) > I had to back this out along with everything else from this push for build > bustage like > https://treeherder.mozilla.org/logviewer.html#?job_id=24870637&repo=mozilla- > inbound > https://hg.mozilla.org/integration/mozilla-inbound/rev/444648c7d761 That looks like it's from a different bug. This bug's patches should be okay on their own, but I'll push them to Try first.
Flags: needinfo?(wmccloskey) → needinfo?(jld)
Comment 10•8 years ago
|
||
Looks safe to reland this one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a4273039499
Flags: needinfo?(jld)
Keywords: checkin-needed
Comment 11•8 years ago
|
||
bugherder landing |
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f68029c49a https://hg.mozilla.org/integration/mozilla-inbound/rev/e107f7eea6cf https://hg.mozilla.org/integration/mozilla-inbound/rev/114cfe94d306
Keywords: checkin-needed
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62f68029c49a https://hg.mozilla.org/mozilla-central/rev/e107f7eea6cf https://hg.mozilla.org/mozilla-central/rev/114cfe94d306
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•