1253123 - Remove some unused Chromium code

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I'm going to try to remove some stuff that we don't use form the Chromium IPC import.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Remove thread_collision_warner

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Remove ipc_sync_message

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Remove message_router

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Remove ipc_channel_proxy

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8726010 [details] [diff] [review]
Remove ipc_sync_message

Review of attachment 8726010 [details] [diff] [review]:
-----------------------------------------------------------------

ipc/chromium/src/chrome/common/ipc_message.h has a `friend class SyncMessage`; it should be harmless, but might as well delete that too.

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8726011 [details] [diff] [review]
Remove message_router

Review of attachment 8726011 [details] [diff] [review]:
-----------------------------------------------------------------

Those ChildThread methods do indeed seem dead.  Nice.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c8278e8047e
https://hg.mozilla.org/integration/mozilla-inbound/rev/d345149b2169
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0dd577131c7

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out along with everything else from this push for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=24870637&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/444648c7d761

Comment 9

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

(In reply to Wes Kocher (:KWierso) from comment #8)
> I had to back this out along with everything else from this push for build
> bustage like
> https://treeherder.mozilla.org/logviewer.html#?job_id=24870637&repo=mozilla-
> inbound
> https://hg.mozilla.org/integration/mozilla-inbound/rev/444648c7d761

That looks like it's from a different bug.  This bug's patches should be okay on their own, but I'll push them to Try first.

Comment 10

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Looks safe to reland this one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a4273039499

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62f68029c49a
https://hg.mozilla.org/integration/mozilla-inbound/rev/e107f7eea6cf
https://hg.mozilla.org/integration/mozilla-inbound/rev/114cfe94d306

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62f68029c49a
https://hg.mozilla.org/mozilla-central/rev/e107f7eea6cf
https://hg.mozilla.org/mozilla-central/rev/114cfe94d306