1253198 - Add common prefix to all ice unit tests

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Nils Ohlmeier [:drno]]

Since ice unit test got converted to mozilla gtest it is pain to manually run them all.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: MozReview Request: Bug 1253198: add WebRtcIce prefix to all ICE unit tests. r=bwc

Review commit: https://reviewboard.mozilla.org/r/37823/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37823/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8726135 [details]
MozReview Request: Bug 1253198: add WebRtcIce prefix to all ICE unit tests. r=bwc

https://reviewboard.mozilla.org/r/37823/#review34425

I think I would prefer to make sure there's an "Ice" prefix on all of this stuff; we can maybe use the "WebRtc" prefix too, but I would expect that to apply to our other unit-tests too, so it wouldn't be useful for selecting the ICE tests.

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8726135 [details]
MozReview Request: Bug 1253198: add WebRtcIce prefix to all ICE unit tests. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37823/diff/1-2/

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8726135 [details]
MozReview Request: Bug 1253198: add WebRtcIce prefix to all ICE unit tests. r=bwc

https://reviewboard.mozilla.org/r/37823/#review34503

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8726135 [details]
MozReview Request: Bug 1253198: add WebRtcIce prefix to all ICE unit tests. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37823/diff/2-3/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e56921407e9

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/9e56921407e9