1253265 - make some nsRestyleHint operators constexpr

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Trevor Saunders (:tbsaunde)]

This gets rid of at least one static constructor

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: make some nsRestyleHint operators constexpr

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8726243 [details] [diff] [review]
make some nsRestyleHint operators constexpr

Review of attachment 8726243 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsChangeHint.h
@@ +463,5 @@
>  // The functions below need an integral type to cast to to avoid
>  // infinite recursion.
>  typedef decltype(nsRestyleHint(0) + nsRestyleHint(0)) nsRestyleHint_size_t;
>  
> +inline MOZ_CONSTEXPR nsRestyleHint operator|(nsRestyleHint aLeft,

Is there any benefit to the "inline" annotation here, or does it become vestigial now that this is MOZ_CONSTEXPR? (evaluated at compile-time)

From a mxr search, it looks like the extremely-vast majority of our MOZ_CONSTEXPR functions do not use "inline". So, if you agree that MOZ_CONSTEXPR makes it unnecessary/redundant/vestigial, feel free to remove that keyword as part of this change.

r=me either way.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Daniel Holbert [:dholbert] (mostly AFK March 3rd - 6th) from comment #2)
> From a mxr search, it looks like the extremely-vast majority of our
> MOZ_CONSTEXPR functions do not use "inline". So, if you agree that
> MOZ_CONSTEXPR makes it unnecessary/redundant/vestigial, feel free to remove
> that keyword as part of this change.

But methods defined inline within the definition of a class are implicitly |inline|, so they don't need |inline|.  These are not class methods, so I think they should have it.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks, that makes sense. The patch should land as-is, then; disregard my question in comment 2.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69d55ff0a1da

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69d55ff0a1da