Not all timing data are carried to the child process

RESOLVED FIXED in Firefox 46

Status

()

Core
Networking: HTTP
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mayhemer, Assigned: valentin)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 wontfix, firefox46 fixed, firefox47 fixed)

Details

(Whiteboard: [necko-active])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Apparently the patch [1], bug 1064706, doesn't carry at least the cache load timings.  This is a major telemetry and timing break.

Valentin, can you please take a look and check what is missing and fix it?


[1] https://bugzilla.mozilla.org/attachment.cgi?id=8500326&action=diff#a/netwerk/protocol/http/HttpChannelParent.cpp_sec3
Flags: needinfo?(valentin.gosu)
(Reporter)

Updated

2 years ago
Status: ASSIGNED → NEW
(Reporter)

Updated

2 years ago
Duplicate of this bug: 1225097
(Assignee)

Comment 2

2 years ago
Created attachment 8726385 [details]
MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab

Review commit: https://reviewboard.mozilla.org/r/37951/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37951/
Attachment #8726385 - Flags: review?(honzab.moz)
(Reporter)

Updated

2 years ago
Attachment #8726385 - Flags: review?(honzab.moz) → review+
(Reporter)

Comment 3

2 years ago
Comment on attachment 8726385 [details]
MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab

https://reviewboard.mozilla.org/r/37951/#review34517

::: netwerk/protocol/http/TimingStruct.h:33
(Diff revision 1)
> +  // the rest of the timings.

please say also WHY.
(Reporter)

Updated

2 years ago
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
Comment on attachment 8726385 [details]
MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37951/diff/1-2/

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/96bf29982e94
Whiteboard: [necko-active]
https://hg.mozilla.org/mozilla-central/rev/96bf29982e94
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Reporter)

Comment 7

2 years ago
Valentin, please nominate this up to beta.
(Assignee)

Comment 8

2 years ago
Comment on attachment 8726385 [details]
MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab

Approval Request Comment

[Feature/regressing bug #]:
Bug 1064706 did not pass all of the timing data to the content process.

[User impact if declined]:
Telementry of cache timing on the content process will report wrong values.

[Describe test coverage new/current, TreeHerder]:
We have tests for other timings, but not cacheReadStart/End.

[Risks and why]: 
This is low risk. It only sends the missing cacheReadStart/End timestamps to the content process. It does not change behaviour, only the data reported in the child process.

[String/UUID change made/needed]:
None.
Flags: needinfo?(valentin.gosu)
Attachment #8726385 - Flags: approval-mozilla-beta?
Attachment #8726385 - Flags: approval-mozilla-aurora?
status-firefox45: --- → wontfix
status-firefox46: --- → affected
Comment on attachment 8726385 [details]
MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab

Too late for 45
Attachment #8726385 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment on attachment 8726385 [details]
MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab

Fix for telemetry issue, we want good info in 46. 
Please uplift to beta (46 is beta now, we just did the merge an hour ago)
Attachment #8726385 - Flags: approval-mozilla-beta-
Attachment #8726385 - Flags: approval-mozilla-beta+
Attachment #8726385 - Flags: approval-mozilla-aurora?
Attachment #8726385 - Flags: approval-mozilla-aurora-
https://hg.mozilla.org/releases/mozilla-beta/rev/bbaf0ef3deea
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.