1253426 - When Fennec is brought to the foreground, soft keyboard needs to be restored if it was previously visible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Randall Barker [:rbarker]]

When Fennec is sent to the background with the keyboard visible. The keyboard will automatically hide when Fennec is brought to the foreground again. The keyboard state should be restored so that it is visible once Fennec is brought to the foreground.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1253426-When-Fennec-is-brought-to-the-foreground-soft-keyboard-needs-to-be-restored-if-it-was-previously-visible-r-16030313-1a40016.patch

Comment 2

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1253426-When-Fennec-is-brought-to-the-foreground-soft-keyboard-needs-to-be-restored-if-it-was-previously-visible-r-16030313-7d0706b.patch

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8726420 [details] [diff] [review]
0001-Bug-1253426-When-Fennec-is-brought-to-the-foreground-soft-keyboard-needs-to-be-restored-if-it-was-previously-visible-r-16030313-7d0706b.patch

Review of attachment 8726420 [details] [diff] [review]:
-----------------------------------------------------------------

I feel like some of this only adds to the pain of a transition to a multi-window world with the addition of stuff to GeckoAppShell. If you handled the 'application-foreground' in nsWindow and then just called restoreIMEState() on the GV from there I think it would be cleaner. Less Java code to write too :)

::: mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
@@ +116,5 @@
>              GeckoAppShell.sendEventToGecko(GeckoEvent.createAppForegroundingEvent());
>              mPausedGecko = false;
>          }
>  
> +        GeckoAppShell.foregroundApp();

I'd rather not add more stuff to GeckoApplication if we can avoid it. I notice right above is where we send the 'application-foreground' event, though, so I guess this is about the same. Blah.

Comment 4

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1253426-When-Fennec-is-brought-to-the-foreground-soft-keyboard-needs-to-be-restored-if-it-was-previously-visible-r-16030316-d9b77ad.patch

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8726491 [details] [diff] [review]
0001-Bug-1253426-When-Fennec-is-brought-to-the-foreground-soft-keyboard-needs-to-be-restored-if-it-was-previously-visible-r-16030316-d9b77ad.patch

Review of attachment 8726491 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/GeckoInputConnection.java
@@ +585,5 @@
>          Editable editable = getEditable();
>          outAttrs.initialSelStart = Selection.getSelectionStart(editable);
>          outAttrs.initialSelEnd = Selection.getSelectionEnd(editable);
> +
> +        if (!GeckoApplication.get().isApplicationInBackground()) {

Another thing we'll have to untangle if we want to run without GeckoApplication, but...alright I guess?

Comment 6

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1253426-When-Fennec-is-brought-to-the-foreground-soft-keyboard-needs-to-be-restored-if-it-was-previously-visible-r-snorp-16030410-f306e02.patch

Updated patch so that it would work with multiple GeckoViews.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60444e696cfc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60444e696cfc

Comment 9

[Alex Caziuc]

Tested using:
Device: Huawei Honor (Android 5.1.1)
Build: Firefox for Android Beta - 47.0b6

Comment 10

[Alex Caziuc]

I'll mark this bug as verified fixed since it is verified.