1253430 - Move most FinalTargetFiles processing into misc tier

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

Currently if any of the FinalTargetFiles variables install an objdir file, that file is installed during the exports tier. However, some of the remaining INSTALL_TARGETS in Makefiles install files that are generated during the compile tier. I believe glandium suggested that we can install these during the misc tier instead, except for Exports of course.

Comment 1

[Michael Shal [:mshal]]

Attachment: MozReview Request: Bug 1253430 - Move most FinalTargetFiles into misc tier; r?glandium

Review commit: https://reviewboard.mozilla.org/r/37987/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37987/

Comment 2

[Mike Hommey [:glandium]]

I was suggesting that we could even move the install manifest processing, and thus make use of install manifests.

Comment 3

[Michael Shal [:mshal]]

Ahh, that makes sense. Mind if I file a followup for that? This still works (according to try), and will unblock some other bugs, even if it is less efficient than using the install manifest processing.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8726430 [details]
MozReview Request: Bug 1253430 - Move most FinalTargetFiles into misc tier; r?glandium

https://reviewboard.mozilla.org/r/37987/#review34639

I'm not too thrilled by adding tier-information to data types, because that's an implementation detail of the recursive make backend that shouldn't transpire. The backend itself can base a decision on the install_target being 'dist/include'.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8726430 [details]
MozReview Request: Bug 1253430 - Move most FinalTargetFiles into misc tier; r?glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37987/diff/1-2/

Comment 6

[Michael Shal [:mshal]]

I filed bug 1253680 as a followup for using install manifests for these files.

Comment 7

[Michael Shal [:mshal]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25112ed32e9c

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8726430 [details]
MozReview Request: Bug 1253430 - Move most FinalTargetFiles into misc tier; r?glandium

https://reviewboard.mozilla.org/r/37987/#review35279

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f088f4be649a

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f088f4be649a