Closed
Bug 1253526
Opened 8 years ago
Closed 8 years ago
Remove DMD's --max-frames option
Categories
(Core :: DMD, defect)
Core
DMD
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(2 files)
7.74 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
1.60 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
DMD has a --max-frames option. dmd.py *also* has a --max-frames option. The latter is highly useful, but the former is not. It has the potential to speed things up by collecting shorter stack traces, but I've never used it and I doubt anyone else has.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
It's rare anyone would see it, and it just duplicates the info present in |mach run|.
Attachment #8726590 -
Flags: review?(erahm)
Comment 3•8 years ago
|
||
Comment on attachment 8726588 [details] [diff] [review] (part 1) - Remove DMD's --max-frames option Review of attachment 8726588 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8726588 -
Flags: review?(erahm) → review+
Updated•8 years ago
|
Attachment #8726590 -
Flags: review?(erahm) → review+
Comment 4•8 years ago
|
||
There's a similar option for ASan, which is used in automation to reduce memory usage, but we don't run DMD like that so that it shouldn't be an issue.
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa57591bfe2454afad4bdbba4aa3a2380c934d7f Bug 1253526 (part 1) - Remove DMD's --max-frames option. r=erahm. https://hg.mozilla.org/integration/mozilla-inbound/rev/b5bbe0866d72f3231ed7188953985b1104de6aa1 Bug 1253526 (part 2) - Gut DMD's usage message. r=erahm
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fa57591bfe24 https://hg.mozilla.org/mozilla-central/rev/b5bbe0866d72
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•