Closed Bug 1253526 Opened 4 years ago Closed 4 years ago

Remove DMD's --max-frames option

Categories

(Core :: DMD, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files)

DMD has a --max-frames option.  dmd.py *also* has a --max-frames option.

The latter is highly useful, but the former is not. It has the potential to speed things up by collecting shorter stack traces, but I've never used it and I doubt anyone else has.
Nobody uses it.
Attachment #8726588 - Flags: review?(erahm)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
It's rare anyone would see it, and it just duplicates the info present in |mach
run|.
Attachment #8726590 - Flags: review?(erahm)
Comment on attachment 8726588 [details] [diff] [review]
(part 1) - Remove DMD's --max-frames option

Review of attachment 8726588 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8726588 - Flags: review?(erahm) → review+
Attachment #8726590 - Flags: review?(erahm) → review+
There's a similar option for ASan, which is used in automation to reduce memory usage, but we don't run DMD like that so that it shouldn't be an issue.
https://hg.mozilla.org/mozilla-central/rev/fa57591bfe24
https://hg.mozilla.org/mozilla-central/rev/b5bbe0866d72
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.