1253526 - Remove DMD's --max-frames option

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Nicholas Nethercote [:njn]]

DMD has a --max-frames option.  dmd.py *also* has a --max-frames option.

The latter is highly useful, but the former is not. It has the potential to speed things up by collecting shorter stack traces, but I've never used it and I doubt anyone else has.

Comment 1

[Nicholas Nethercote [:njn]]

Attachment: (part 1) - Remove DMD's --max-frames option

Nobody uses it.

Comment 2

[Nicholas Nethercote [:njn]]

Attachment: (part 2) - Gut DMD's usage message

It's rare anyone would see it, and it just duplicates the info present in |mach
run|.

Comment 3

[Eric Rahm (on leave)]

Comment on attachment 8726588 [details] [diff] [review]
(part 1) - Remove DMD's --max-frames option

Review of attachment 8726588 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 4

[Andrew McCreight [:mccr8]]

There's a similar option for ASan, which is used in automation to reduce memory usage, but we don't run DMD like that so that it shouldn't be an issue.

Comment 5

[Nicholas Nethercote [:njn]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa57591bfe2454afad4bdbba4aa3a2380c934d7f
Bug 1253526 (part 1) - Remove DMD's --max-frames option. r=erahm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5bbe0866d72f3231ed7188953985b1104de6aa1
Bug 1253526 (part 2) - Gut DMD's usage message. r=erahm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fa57591bfe24
https://hg.mozilla.org/mozilla-central/rev/b5bbe0866d72