1253537 - [Dev theme dark] Dark favicon is barely visible

Status: RESOLVED DUPLICATE of bug 1094357

(Firefox :: Theme, defect)

Description

[modestdev]

Attachment: Screen Shot 2016-03-04 at 11.20.10.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160210153822

Steps to reproduce:

1. Set dark edition of "Developer Edition" theme.
2. Open website with dark favicon (github.com).


Actual results:

Website favicon is barely visible.


Expected results:

Website favicon should be visible.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I think Theme is a better fit...?  Not sure.

Comment 2

[marc]

Attachment: Screen Shot 2017-11-20 at 23.09.12.png

Comment 3

[marc]

Hi

I've upgraded to Firefox Quantum and I confirm the new default dark theme does not do well with websites using a dark/black favicon, e.g. https://feedbin.com (see screenshot "Screen Shot 2017-11-20 at 23.09.12.png " attached). Could you please do something, for example add a light border around black/dark favicons?

Thanks,

m.

Comment 4

[marc]

Edit: this is especially visible when pinning the website tab.

Comment 5

[Scott Palmer]

What are you expecting the Mozilla team to do about this? This is not a "bug" as the software is doing what it is supposed to.

File an issue with github / Microsoft to put a border around their favicon.ico so it shows up better when dark themes are enabled.
Make sure the screenshot is using Chromium Edge browser in dark mode :). MS browser on MS website... Developers are often big proponents of dark themes so it makes sense.

Another possibility is for the Mozilla and Google people to discuss a new standard for favicon.ico and possibly add a:
favicon.ico and optional favicon-dark.ico. If they are discussing improving the "standard" which isn't really a standard then Apple should be brought in but they, as expected, don't care about anybody else usually and do their own "standard".

Perhaps the fruit is ripe though (pun intended) as Microsoft and Apple now both have a dark mode in their OS (Linux has had often broken dark mode for a long time)

Comment 6

[Dibo]

I can also confirm issue with spotify webplayer. Wrong accent favicon on dark theme. Opera can choose correct one. Vivaldi had same problem as FireFox but after my report they fixed it

Comment 7

[Dibo]

Today Spotify has correct accent favicon on FireFox dark theme (green icon instead of black) but I didn't get any FF updates. So seems that it was fixed on spotify side, interesting