1253549 - Screenshot button doesn't work with sites on https://transvision-beta.mozfr.org/consistency/?locale=fr&repo=aurora

Status: RESOLVED DUPLICATE of bug 766661

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P1)

Description

[Pascal Chevrel (relman team) -> :pascalc]

Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0

(same bug in Firefox 44)

1/ Work on you machine on localhost (in my case I use the PHP integrated dev server which gives me a site at http://localhost:8082/)

2/ click on the screenshot capture button in devtools to get a screenshot of your work

expected result:
A screen capture is done

actual result:
No screenshot and this error in the console:
<unavailable> cli.js:2054
Object { isTypedData: true, data: Object, type: "error" } cli.js:2054
Object { columnNumber: 0, lineNumber: 302, message: "", stack: "createScreenshotData@resource://gre…" } cli.js:2054

Comment 1

[Pascal Chevrel (relman team) -> :pascalc]

Apparently it's not related to localhost, I just tried doing a screenshot of the same page on a real server and I also get an error:
https://transvision-beta.mozfr.org/consistency/?locale=fr&repo=aurora

Exception { message: "", result: 2147500037, name: "NS_ERROR_FAILURE", filename: "resource://gre/modules/commonjs/too…", lineNumber: 299, columnNumber: 0, inner: null, data: null, stack: "createScreenshotData@resource://gre…", location: XPCWrappedNative_NoHelper } cli.js:2054
Object { isTypedData: true, data: Object, type: "error" } cli.js:2054
Object { columnNumber: 0, lineNumber: 299, message: "", stack: "createScreenshotData@resource://gre…" } cli.js:2054

Comment 2

[Patrick Brosset <:pbro>]

Ah, I was commenting at the same time as you posted comment 1, was about to say that it worked for me with FF46 and 47.
But I tried with the URL you provided and it does indeed fail for me too (FF47 windows).

The error message you provided points to the createScreenshotData function in devtools\shared\gcli\commands\screenshot.js

I'll investigate a little bit now.

Comment 3

[Patrick Brosset <:pbro>]

So on this particular site, scaling the canvas 2dcontext (ctx.scale(ratio, ratio)) fails with NS_ERROR_FAILURE.
This is done here in [1] and the scale transformation implementation seems to be here [2]

I don't know why IsTargetValid() would return false for this page only, and work on other pages though.
I haven't been able to reproduce this by running the screenshot code in scratchpad.

Benoit: as someone who's work on CanvasRenderingContext2D.cpp a lot, could you please help us understand why the devtools screenshot command fails on this particular site (see [1], calling ctx.scale fails)?

[1] https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/commands/screenshot.js#302
[2] https://dxr.mozilla.org/mozilla-central/source/dom/canvas/CanvasRenderingContext2D.cpp#1762

Comment 4

[Théo Chevalier]

FWIW, I can reproduce this bug on Mac OS with today's Nightly.


<unavailable> cli.js:2054
Object { isTypedData: true, data: Object, type: "error" } cli.js:2054
Object { columnNumber: 0, lineNumber: 302, message: "", stack: "createScreenshotData@resource://gre…" } cli.js:2054

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Tentatively moving to GCLI, thought it may be a platform issue in the end.

Comment 6

[Joe Walker [:jwalker]]

I think this is almost certainly the same as bug 766661, I'd like to hear from anyone that knows the platform code.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

(I'm no longer at Mozilla)