1253556 - response source for requests not shown as tooltip (set as 'code' attribute)

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 46.0a2 20160303004038, Windows 8.1

Bug 1158264 added strings for showing the source of the response for network requests in the Network panel of the developer toolbox.

These are never shown to the users but set as values of the 'code' attribute. Is that of any use? If not, please fix it or remove the code.

Furthermore, this should also be fixed (also from bug 1158264):
> code = L10N.getStr("netmonitor.status.cached");
> code = "cached";

Also in the request list, the icon is a hollow circle while in the details pane it's a full one for the same request which gets served from cache.

In 47.0a1, the HTTP status shows 304 (instead of 200 in 46.0a2) and the Size and Transferred columns always values. The former one shows that the response is from cache in 46.0a2.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Let's ask :ochameau, since he added the original feature.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Remove unnecessary netmonitor.status.* strings.

Thanks for the report!

You're right. I thought these strings were somehow used in the interface,
but no. It is only used in CSS to set the right color for the status circle
and in tests.

Regarding the actual color being used for service worker, I don't know.
May be we should ping Helen to give some thoughts on what color we should use for service worker requests.

Otherwise I think the changes you see with status code are correct,
before we were just wrong when service worker were involved.
Now we expose the two requests, the one being done within the service worker (which we used to display as "cached")
and the one being done by the webpage itself (which wasn't shown before and relates to the one being served by the SW)

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8731635 [details] [diff] [review]
Remove unnecessary netmonitor.status.* strings.

Review of attachment 8731635 [details] [diff] [review]:
-----------------------------------------------------------------

test?

Comment 4

[Alexandre Poirot [:ochameau]]

This is being tested over here:
  http://mxr.mozilla.org/mozilla-central/source/devtools/client/netmonitor/test/head.js#327
  http://mxr.mozilla.org/mozilla-central/source/devtools/client/netmonitor/test/browser_net_service-worker-status.js#48

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbbcaa37c45c

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/369755dd7d41e76cb409514debb8e62be71ee205
Bug 1253556 - Remove unnecessary netmonitor.status.* strings. r=vporof

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/369755dd7d41