Closed
Bug 1253559
Opened 8 years ago
Closed 8 years ago
The edit menu for rooms can go off the panel display
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: dcritchley)
References
()
Details
(Whiteboard: [btpp-fix-now])
Attachments
(3 files)
Screen shot of issue
Since we added the "Edit name" option to the edit menu for the rooms in the panel, there's now a possibility that when displayed, the menu will be partially off the display. I've seen it as bad as covering up the majority of the text for the top or bottom-most item. The shorter panel heights with just a few rooms potentially don't help us here either.
|
Reporter | |
Updated•8 years ago
|
Rank: 5
Whiteboard: [btpp-fix-now]
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → dcritchley
|
|
Assignee | |
Comment 1•8 years ago
|
||
If menu is less than 0 from top then make 0. Do we want to leave it at 0 or drop it down one pixel?
Attachment #8726939 -
Flags: ui-review?(sfranks)
|
||
Comment 2•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8726943 -
Flags: review?(edilee)
Attachment #8726943 -
Flags: review?(dmose)
Attachment #8726943 -
Flags: review?(crafuse)
|
||
Updated•8 years ago
|
Attachment #8726943 -
Flags: review?(edilee)
Attachment #8726943 -
Flags: review?(dmose)
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8726943 [details] [review] [loop] daveccrit:1253559-editMenuPosition > mozilla:master Looks good.
Attachment #8726943 -
Flags: review?(crafuse) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
I still need to add a unit test for this, will push up for review once that is done
|
||
Updated•8 years ago
|
Attachment #8726939 -
Flags: ui-review?(sfranks) → ui-review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8726943 -
Flags: review+ → review?(crafuse)
|
|
Assignee | |
Comment 5•8 years ago
|
||
significant changes, needs fresh review.
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8726943 [details] [review] [loop] daveccrit:1253559-editMenuPosition > mozilla:master Looks good.
Attachment #8726943 -
Flags: review?(crafuse) → review+
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•