bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

The edit menu for rooms can go off the panel display

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
5
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: dcritch)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now], URL)

Attachments

(3 attachments)

Created attachment 8726666 [details]
Screen shot of issue

Since we added the "Edit name" option to the edit menu for the rooms in the panel, there's now a possibility that when displayed, the menu will be partially off the display.

I've seen it as bad as covering up the majority of the text for the top or bottom-most item.

The shorter panel heights with just a few rooms potentially don't help us here either.
Rank: 5
Whiteboard: [btpp-fix-now]
(Assignee)

Updated

2 years ago
Assignee: nobody → dcritchley
(Assignee)

Comment 1

2 years ago
Created attachment 8726939 [details]
Snapshot if fixed menu

If menu is less than 0 from top then make 0.  Do we want to leave it at 0 or drop it down one pixel?
Attachment #8726939 - Flags: ui-review?(sfranks)
Created attachment 8726943 [details] [review]
[loop] daveccrit:1253559-editMenuPosition > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8726943 - Flags: review?(edilee)
Attachment #8726943 - Flags: review?(dmose)
Attachment #8726943 - Flags: review?(crafuse)

Updated

2 years ago
Attachment #8726943 - Flags: review?(edilee)
Attachment #8726943 - Flags: review?(dmose)
Comment on attachment 8726943 [details] [review]
[loop] daveccrit:1253559-editMenuPosition > mozilla:master

Looks good.
Attachment #8726943 - Flags: review?(crafuse) → review+
(Assignee)

Comment 4

2 years ago
I still need to add a unit test for this, will push up for review once that is done
Attachment #8726939 - Flags: ui-review?(sfranks) → ui-review+
(Assignee)

Updated

2 years ago
Attachment #8726943 - Flags: review+ → review?(crafuse)
(Assignee)

Comment 5

2 years ago
significant changes, needs fresh review.
Comment on attachment 8726943 [details] [review]
[loop] daveccrit:1253559-editMenuPosition > mozilla:master

Looks good.
Attachment #8726943 - Flags: review?(crafuse) → review+

Updated

2 years ago
Blocks: 1248604
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.