Closed Bug 1253566 Opened 4 years ago Closed 4 years ago

VC2015 compile fails with C2664

Categories

(Core :: Widget: Win32, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

12:31.94 f:/m/mozilla-central/widget/windows/WinUtils.cpp(1922): error C2664: 'BOOL PathUnExpandEnvStringsW(LPCWSTR,LPWSTR,UINT)': 引数 2 を 'nsAString_internal::char_iterator' から 'LPWSTR' へ変換できません。
12:31.94 f:/m/mozilla-central/widget/windows/WinUtils.cpp(1922): note: 指示され た型は関連がありません。変換には reinterpret_cast、C スタイル キャストまたは関数スタイルのキャストが必要です。
12:31.94 f:/m/mozilla-central/widget/windows/WinUtils.cpp(1926): error C2664: 'size_t wcslen(const wchar_t *)': 引数 1 を 'nsAString_internal::const_char_iterator' から 'const wchar_t *' へ変換できません。
12:31.94 f:/m/mozilla-central/widget/windows/WinUtils.cpp(1926): note: 指示され た型は関連がありません。変換には reinterpret_cast、C スタイル キャストまたは関数スタイルのキャストが必要です。

Please do not mix LPWSTR and char16_t.
Flags: needinfo?(aklotz)
Flags: needinfo?(aklotz)
Attachment #8726686 - Flags: review?(aklotz)
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Component: Startup and Profile System → Widget: Win32
Product: Toolkit → Core
Comment on attachment 8726686 [details] [diff] [review]
Deal with char16_t/wchar_t mismatch

Review of attachment 8726686 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8726686 - Flags: review?(aklotz) → review+
https://hg.mozilla.org/mozilla-central/rev/1ea5c28a280f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.