Closed Bug 1253617 Opened 4 years ago Closed 4 years ago

Non-unified build bustage in OverscrollHandoffState.cpp

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
InputData is used but not declared in OverscrollHandoffState.h
Attachment #8726760 - Flags: review?(bgirard)
Comment on attachment 8726760 [details] [diff] [review]
Patch

Review of attachment 8726760 [details] [diff] [review]:
-----------------------------------------------------------------

I see a lot of these issues, particularly in the APZ code, with clang-complete since it performs completion on the current file without unification. A few months ago in a review you asked why random header changes kept making it into my patches and I couldn't remember why. It was actually just me fixing the includes for clang-complete and I forgot about it. Just mentioning this since clang-complete is a good way to make sure that files build fine without unification.
Attachment #8726760 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/a65a2b2cadc2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.