Closed
Bug 1253617
Opened 8 years ago
Closed 8 years ago
Non-unified build bustage in OverscrollHandoffState.cpp
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
1.00 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
InputData is used but not declared in OverscrollHandoffState.h
Attachment #8726760 -
Flags: review?(bgirard)
Comment 1•8 years ago
|
||
Comment on attachment 8726760 [details] [diff] [review] Patch Review of attachment 8726760 [details] [diff] [review]: ----------------------------------------------------------------- I see a lot of these issues, particularly in the APZ code, with clang-complete since it performs completion on the current file without unification. A few months ago in a review you asked why random header changes kept making it into my patches and I couldn't remember why. It was actually just me fixing the includes for clang-complete and I forgot about it. Just mentioning this since clang-complete is a good way to make sure that files build fine without unification.
Attachment #8726760 -
Flags: review?(bgirard) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a65a2b2cadc2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•