1253646 - Implement browser.extension.isAllowedFileSchemeAccess

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Andy McKay]

As per https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedFileSchemeAccess

Comment 1

[Kris Maglione [:kmag]]

For the moment, this can just be a stub that returns `true`, since we don't currently have a special setting for this.

Comment 2

[Christopher Grebs [:cgrebs]]

Attachment: MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag

Review commit: https://reviewboard.mozilla.org/r/45757/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45757/

Comment 3

[Christopher Grebs [:cgrebs]]

Comment on attachment 8740425 [details]
MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45757/diff/1-2/

Comment 4

[Christopher Grebs [:cgrebs]]

Comment on attachment 8740425 [details]
MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45757/diff/2-3/

Comment 5

[Christopher Grebs [:cgrebs]]

Ugh, sorry for the unneccessary updates, I messed up my commits :-/

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8740425 [details]
MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag

https://reviewboard.mozilla.org/r/45757/#review42437

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1bac204229b4

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/32d2e4645dde

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed https://hg.mozilla.org/integration/fx-team/rev/32d2e4645dde3cdbdaec76721f733b95c8bf7ef5 as follow-up to use the desired JavaScript code style by adding a semicolon after a statement. ESLint failure was https://treeherder.mozilla.org/logviewer.html#?job_id=8663279&repo=fx-team

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1bac204229b4
https://hg.mozilla.org/mozilla-central/rev/32d2e4645dde

Comment 11

[Will Bamberg [:wbamberg]]

-> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedFileSchemeAccess#Browser_compatibility