Closed
Bug 1253646
Opened 8 years ago
Closed 8 years ago
Implement browser.extension.isAllowedFileSchemeAccess
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: andy+bugzilla, Assigned: cgrebs, Mentored)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [extension][good first bug][berlin])
Attachments
(1 file)
As per https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedFileSchemeAccess
Comment 1•8 years ago
|
||
For the moment, this can just be a stub that returns `true`, since we don't currently have a special setting for this.
Mentor: kmaglione+bmo
Keywords: dev-doc-needed
Summary: Implement chrome.extension.isAllowedFileSchemeAccess → Implement browser.extension.isAllowedFileSchemeAccess
Whiteboard: [extension][good first bug][berlin]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cgrebs
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45757/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45757/
Attachment #8740425 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8740425 [details] MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45757/diff/1-2/
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8740425 [details] MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45757/diff/2-3/
Assignee | ||
Comment 5•8 years ago
|
||
Ugh, sorry for the unneccessary updates, I messed up my commits :-/
Comment 6•8 years ago
|
||
Comment on attachment 8740425 [details] MozReview Request: Bug 1253646 - Implement browser.extension.isAllowedFileSchemeAccess. r?kmag https://reviewboard.mozilla.org/r/45757/#review42437
Attachment #8740425 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 9•8 years ago
|
||
Pushed https://hg.mozilla.org/integration/fx-team/rev/32d2e4645dde3cdbdaec76721f733b95c8bf7ef5 as follow-up to use the desired JavaScript code style by adding a semicolon after a statement. ESLint failure was https://treeherder.mozilla.org/logviewer.html#?job_id=8663279&repo=fx-team
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bac204229b4 https://hg.mozilla.org/mozilla-central/rev/32d2e4645dde
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 11•8 years ago
|
||
-> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/Extension/isAllowedFileSchemeAccess#Browser_compatibility
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•