Closed Bug 1253713 Opened 7 years ago Closed 7 years ago

[e10s] Make widget/tests/test_plugin_scroll_invalidation.html work under e10s


(Core Graveyard :: Plug-ins, defect)

Not set


(firefox47 fixed)

Tracking Status
firefox47 --- fixed


(Reporter: adw, Assigned: adw)


(Blocks 1 open bug)



(1 file)

Attached patch patchSplinter Review
[e10s] Make widget/tests/test_plugin_scroll_invalidation.html work under e10s.

Andrew, this patch is based off your patch in bug 1237799.  It moves the test to dom/plugins/test/mochitest/ and calls setTestPluginEnabledState, which fixes the test locally for me on e10s and also it looks like on try (but I don't understand why :-))
Attachment #8726905 - Flags: review?(continuation)
Attachment #8726905 - Attachment is patch: true
The reason the patch works is that the implementation of setTestPluginEnabledState in the widget directory is broken in e10s (it tries to set the property directly, but that can't be done in the content process):

but the one in plugin-utils has been fixed (it uses a special powers function to send a message to the parent process that actually does the change, or something like that):

The basic problem is that people copied and pasted this broken setTestPluginEnableState thing all over the place.

I guess the widget utils.js one can't just be fixed because there are still other Mochitest Chrome tests that use it.

Ideally, SpecialPowers.testPluginState() would be fixed to not require a wrapper like this and then we wouldn't need plugin-utils.js but nobody has gotten around to it.
Anyways, I filed bug 1253742 for making SpecialPowers nicer but I guess this is okay for now.
Attachment #8726905 - Flags: review?(continuation) → review+
Shoulda pushed that to inbound....
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.