incorrect forward-declaration of ShadowLayerForwarder causing build error

RESOLVED FIXED in Firefox 47

Status

()

Core
Graphics: Layers
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

With some local changes I got a build error because ShadowLayerForwarder is incorrectly forward-declared inside mozilla::layout instead of mozilla::layers, in LayerTransactionChild.h.

I'll put up a patch for this shortly.
Created attachment 8726938 [details]
MozReview Request: Bug 1253739 - Fix incorrect namespace on forward declaration. r?sotaro

Review commit: https://reviewboard.mozilla.org/r/38335/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38335/
Attachment #8726938 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8726938 [details]
MozReview Request: Bug 1253739 - Fix incorrect namespace on forward declaration. r?sotaro

https://reviewboard.mozilla.org/r/38335/#review34931

Drive-by r+
Attachment #8726938 - Flags: review+
Thanks!

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fd2d0f7ce49

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8fd2d0f7ce49
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1253860
Comment on attachment 8726938 [details]
MozReview Request: Bug 1253739 - Fix incorrect namespace on forward declaration. r?sotaro

https://reviewboard.mozilla.org/r/38335/#review34967
Attachment #8726938 - Flags: review?(sotaro.ikeda.g) → review+
You need to log in before you can comment on or make changes to this bug.