1253749 - Branch specifics for relpro on beta

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

Apparently we are using nightly mozconfigs. Need a small tweak in testing/mozharness/configs/builds/branch_specifics.py

Comment 1

[Rail Aliiev [:rail]]

Attachment: branch-specifics.diff

Comment 2

[Rail Aliiev [:rail]]

Attachment: l10n.diff

and l10n (ported from date)

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8726950 [details] [diff] [review]
branch-specifics.diff

Review of attachment 8726950 [details] [diff] [review]:
-----------------------------------------------------------------

we are going to have to add 'beta' as the update_channel on monday. Once we do that, all CI jobs that are not 'promoted' will have that anyway right?

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8726957 [details] [diff] [review]
l10n.diff

Review of attachment 8726957 [details] [diff] [review]:
-----------------------------------------------------------------

exciting!

::: testing/mozharness/configs/single_locale/mozilla-beta.py
@@ +2,5 @@
> +    "nightly_build": True,
> +    "branch": "mozilla-beta",
> +    "en_us_binary_url": "http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-beta/",
> +    "update_channel": "beta",
> +    "latest_mar_dir": '/pub/mozilla.org/firefox/nightly/latest-mozilla-beta-l10n',

this was 'fake_kill_me' on date. OOC what happened on date when upload_env['LATEST_MAR_DIR'] was a non falsey value like that?

@@ +9,5 @@
> +    "hg_l10n_base": "https://hg.mozilla.org/releases/l10n/mozilla-beta",
> +
> +    # mar
> +    # No nightly on beta, using aurora mar tools
> +    "mar_tools_url": "http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/mar-tools/%(platform)s",

will this be on beta after uplift?

Comment 5

[Rail Aliiev [:rail]]

(In reply to Jordan Lund (:jlund) from comment #3)
> Comment on attachment 8726950 [details] [diff] [review]
> branch-specifics.diff
> 
> Review of attachment 8726950 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> we are going to have to add 'beta' as the update_channel on monday. Once we
> do that, all CI jobs that are not 'promoted' will have that anyway right?

It's already "beta" in http://hg.mozilla.org/releases/mozilla-beta/file/tip/testing/mozharness/configs/builds/branch_specifics.py#l53, but not used unless it's either nightly (no nightlies on beta) or release_promotion (this patch). See MOZ_UPDATE_CHANNEL logic in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#832

Comment 6

[Rail Aliiev [:rail]]

(In reply to Jordan Lund (:jlund) from comment #4)
> exciting!

Can't wait!
 
> > +    "latest_mar_dir": '/pub/mozilla.org/firefox/nightly/latest-mozilla-beta-l10n',
> 
> this was 'fake_kill_me' on date. OOC what happened on date when
> upload_env['LATEST_MAR_DIR'] was a non falsey value like that?

AFAIK it's not used anywhere, but I don't want to add more risk now. It deserves a clean up in a different bug.

> > +    "mar_tools_url": "http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/mar-tools/%(platform)s",
> 
> will this be on beta after uplift?

Yes and no. They will be generated, but they won't go into the latest directory (nightlies only). :( 

We should change the logic to use the martools, generated by en-US CI build. We already passing the prefix, so we can easily modify the script to use them. I'll file a separate bug.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8726950 [details] [diff] [review]
branch-specifics.diff

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4bbcd3b6e7e

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8726957 [details] [diff] [review]
l10n.diff

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4bbcd3b6e7e

Comment 9

[Rail Aliiev [:rail]]

pushed to aurora as well: https://hg.mozilla.org/releases/mozilla-aurora/rev/d96c772d116e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d4bbcd3b6e7e