1253973 - Hello button has increased height on HiDPI 125%

Status: VERIFIED INCOMPLETE

(Hello (Loop) :: Client, defect)

Description

[arni2033]

+++ This bug was initially created as a clone of Bug #1233701 +++

>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160229030448
STR:
1. Create new profile, launch it
2. Set DPI -> 125% :
 A) Set that DPI level -> 125% in your OS   [OR]
 B) Set layout.css.devPixelsPerPx -> 1.25
3. Right-click Hello button on navigation toolbar, click "Move to menu"

Result:       Navigation toolbar height reduced by ~1 pixel (visually)
Expectations: It should always have the same height

Notes:
1) This is regression between Release 44 and Nightly 47. Looks like this was missed in bug 1233701
2) Request screenshots/screencasts if necessary

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

A screencast (or at least a screenshot) would be very helpful in prioritizing this based on how visually jarring it is.

Comment 2

[arni2033]

To record this video, I used bug 1171394.
Screencast:
> https://dl.dropboxusercontent.com/s/nnq61ehgyfnr90u/screencast%20bug%201253973%20comment%202.webm

Comment 3

[arni2033]

IMO severety of each real bug is more than any enhancement or buggy brand new stuff.
Screencast_2:
> https://dl.dropboxusercontent.com/s/xc04emff3wlcfie/screencast%20bug%201253973%20comment%203.webm

STR_2:
0. Disable buggy e10s thing
1. Open https://www.mozilla.org/en-US/firefox/nightly/firstrun/?oldversion=44.0.2
2. Click Hello button, click "Browse this page with a friend", hover mouse over Hello button in 1s.
3. Wait until hello window will open at the bottom side of the screen
4. Click Hello button, click "Disconnect", wait until hello button will become black

AR:  In Steps 2 and 4, toolbar is twitching
ER:  No twitching: there's already enough twitching in Mozilla's browser

Comment 4

[Mark Banner (:standard8)]

Could you retry this, but using the latest version of our code? We've made some fixes for how the buttons are working, and hopefully they should fix this.

If you use Firefox 46 or later, then you can install this add-on:

https://addons.mozilla.org/firefox/downloads/latest-beta/676057/addon-676057-latest.xpi?src=dp-btn-devchannel

You're fine to uninstall it again after the test.

Comment 5

[arni2033]

1) This particular bug is fixed in that extension. However, I noticed at least 3 bug at the first
   sight. Is Bugzilla a right place to file them or is there some more convenient github page?
2) [in case you know] Is that expected that unsigned extension can only be installed by
   drag-n-dropping the downloaded file to about:addons -> Extensions? It feels hacky.

Comment 6

[:Gijs (he/him)]

(In reply to arni2033 from comment #5)
> 1) This particular bug is fixed in that extension. However, I noticed at
> least 3 bug at the first
>    sight. Is Bugzilla a right place to file them or is there some more
> convenient github page?
> 2) [in case you know] Is that expected that unsigned extension can only be
> installed by
>    drag-n-dropping the downloaded file to about:addons -> Extensions? It
> feels hacky.

Comment 7

[Mark Banner (:standard8)]

(In reply to :Gijs Kruitbosch from comment #6)
> (In reply to arni2033 from comment #5)
> > 1) This particular bug is fixed in that extension. However, I noticed at
> > least 3 bug at the first
> >    sight. Is Bugzilla a right place to file them or is there some more
> > convenient github page?

Yes, bugzilla is where we track all our bugs.

> > 2) [in case you know] Is that expected that unsigned extension can only be
> > installed by
> >    drag-n-dropping the downloaded file to about:addons -> Extensions? It
> > feels hacky.

You should be able to drop an extension onto almost any tab containing a web page and it'll still install. If you're using the developer add-on I reference in comment 4, that should be signed.

Comment 8

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.