1253977 - <select> displays focus outline even if it's not focused and has no "-moz-focusring" pseudoclass

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P4)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160229030448. DEFAULT THEME
STR:
1. Open attached "testcase 1"
2. Click on the free place on page, press Ctrl+Shift+R
3. Press Tab key

AR:  <select> displays focus outline even if it's not focused and has no "-moz-focusring" pseudoclass
ER:  <select> shouldn't display focus outline

Note:
 This testcase was originally made by me for bug 1214293. It's not connected to this one

Comment 3

[Mats Palmgren (inactive)]

Attachment: part 1 - Update focus state on combobox frame destruction/construction properly.

Comment 4

[Mats Palmgren (inactive)]

Attachment: part 2 - Reftests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1663914beafe

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eaa71dfff611
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7e01671e85f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/10ca86638682 for reftest failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=23288702&repo=mozilla-inbound

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eaa71dfff611

Comment 8

[Mats Palmgren (inactive)]

Shouldn't this be backed out on m-c too? 
or perhaps it was but not noted by the bot for some reason?

Anyway, I'm still trying to make the reftests work, but ~12 hours to get results
from Try on Win8 doesn't help much :-(
https://treeherder.mozilla.org/#/jobs?repo=try&revision=054925a1fc85

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

After a bit of digging, I see what happened. I backed out both patches in a single, squashed backout commit. Normally, it records all of the csets into the backout commit message, but this time it looks like it only recorded one of the csets in there, so when Tomcat used Bugherder to mark the merge, Bugherder only saw that half of the bug had been backed out, so went ahead and marked the other part as merged.

I checked the backout commit, though, and it includes the backout for both parts, so this actually was backed out fully, and it's just our tools that screwed up, not the code or either sheriff.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/009922b47d80
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c6911b972d1

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/009922b47d80
https://hg.mozilla.org/mozilla-central/rev/0c6911b972d1

Comment 12

[arni2033]

Fixed on:   Win7_64, Nightly 48, 32bit, ID 20160317030235