1254012 - [e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: MozReview Request: Bug 1254012 - [e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s. r?gijs

Review commit: https://reviewboard.mozilla.org/r/38399/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38399/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae481af73f3

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8727261 [details]
MozReview Request: Bug 1254012 - [e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s. r?gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38399/diff/1-2/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cf6be9ec0ab

Comment 5

[:Gijs (away/busy until Mar 10)]

Comment on attachment 8727261 [details]
MozReview Request: Bug 1254012 - [e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s. r?gijs

https://reviewboard.mozilla.org/r/38399/#review35001

So much more readable, it's amazing. Thanks!

::: browser/base/content/test/general/browser_tabMatchesInAwesomebar_perwindowpb.js:44
(Diff revision 2)
> -           "The test tab has 1 or less history entries");
> +     "The test tab has 1 or less history entries");

Nit: 1 or fewer.

Also, can you include sessionHistoryCount in the message so we know what it is if this ever starts failing?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for check-in

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/691020705d48

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/691020705d48

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8727385 [details] [diff] [review]
Patch for check-in

Approval Request Comment
[Feature/regressing bug #]: e10s test fix
[User impact if declined]: n/a
[Describe test coverage new/current, TreeHerder]: automated test
[Risks and why]: no risk, doesn't touch production code
[String/UUID change made/needed]: none

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8727385 [details] [diff] [review]
Patch for check-in

Test-only fix.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8893af0b7e81