Closed Bug 1254012 Opened 5 years ago Closed 5 years ago

[e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Patch for check-in
9.16 KB, patch
jaws
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
No description provided.
Comment on attachment 8727261 [details]
MozReview Request: Bug 1254012 - [e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s. r?gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38399/diff/1-2/
Attachment #8727261 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8727261 [details]
MozReview Request: Bug 1254012 - [e10s] Fix browser_tabMatchesInAwesomebar_perwindowpb.js to run in e10s. r?gijs

https://reviewboard.mozilla.org/r/38399/#review35001

So much more readable, it's amazing. Thanks!

::: browser/base/content/test/general/browser_tabMatchesInAwesomebar_perwindowpb.js:44
(Diff revision 2)
> -           "The test tab has 1 or less history entries");
> +     "The test tab has 1 or less history entries");

Nit: 1 or fewer.

Also, can you include sessionHistoryCount in the message so we know what it is if this ever starts failing?
Attachment #8727261 - Attachment is obsolete: true
Attachment #8727385 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/691020705d48
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8727385 [details] [diff] [review]
Patch for check-in

Approval Request Comment
[Feature/regressing bug #]: e10s test fix
[User impact if declined]: n/a
[Describe test coverage new/current, TreeHerder]: automated test
[Risks and why]: no risk, doesn't touch production code
[String/UUID change made/needed]: none
Attachment #8727385 - Flags: approval-mozilla-aurora?
Comment on attachment 8727385 [details] [diff] [review]
Patch for check-in

Test-only fix.
Attachment #8727385 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.