125403 - nsconv does not work

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Masaki Katakai]

nsconv does not work because 

NS_InitXPCOM2(nsnull, nsnull, nsnull);

is missing.

Comment 1

[Masaki Katakai]

Attachment: simple patch

Comment 2

[Roy Yokoyama]

Comment on attachment 69394 [details] [diff] [review]
simple patch

/r=yokoyama
thanks, katakai-san

Comment 3

[Roy Yokoyama]

-> over to [e-mail]

Comment 4

[Masaki Katakai]

Thank you, Yokoyama-san,

Do you think I need super-review for this?

Comment 5

[Roy Yokoyama]

>Do you think I need super-review for this?
I believe so.

Comment 6

[Roland Mainz]

Two months without getting any response from superreviewers after a couple of
requests... that's bad... ;-(

Taking myself...

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 69394 [details] [diff] [review]
simple patch

sr=roc+moz

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Katakai-san --- who did you ask for a super-review?

You should direct a super-review request at a specific person. If you just mail
[e-mail] then it will be ignored. Choose your target and then email
them relentlessly :-). If they don't respond after a few emails, complain to
[e-mail].

Comment 9

[Roland Mainz]

Patch checked-in, marking bug as FIXED.

Comment 10

[Roland Mainz]

katakai:
Should I request a= for the 1.0.1-branch ?

Comment 11

[Masaki Katakai]

Many thanks, Roland and Robert!!

I don't think we need this fix for 1.0.1-branch.

Comment 12

[Teruko Kobayashi]

I changed QA contact to [e-mail].
Roy, would you mark this bug as verified if you can verify the fix was checked in.

Comment 13

[Roy Yokoyama]

verified in trunk

Comment 14

[Simon Montagu :smontagu]

*** Bug 123072 has been marked as a duplicate of this bug. ***