Closed Bug 1254129 Opened 8 years ago Closed 8 years ago

[Sync] Device name not updated when synced (device name synced alone)

Categories

(Firefox :: Sync, defect, P1)

47 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 49
Tracking Status
firefox47 blocking verified
firefox48 --- verified
firefox49 --- verified

People

(Reporter: aflorinescu, Assigned: lina)

References

Details

Attachments

(1 file)

[Affected versions]:
- Latest Nightly 47.0a1 (20160307030208)

[Affected platforms]:
- Mac OS X 
- Ubuntu 14.04 32-bit / 15.04 64-bit
- Windows 10

[Steps to reproduce]:
1. Create two profiles or use two machines.
2. Use an empty sync account or reset one.
3. Open no tabs and login on both profiles/machines.
4. Change device name and sync both profiles/machines.
5. View Sync Tabs Sidebar / or Sidebar device names.

[Expected result]:
- In sync tabs Sidebar the changed device name should be visible.

[Actual result]:
- Old initial name still unchanged.

[Regression range]:
- Definitely a regression. First 47.0a1 (2016/02/2016-02-01-03-02-41-mozilla-central/) build behaves as expected. Let me know if a regression range is needed, I need to manually reduce the regression range in this case. 


[Additional notes]:
- Any other change will trigger to get the changed device name successfully - for example if you get a tab to sync with the device name.
- The above steps are reproducible in a normal environment, for example if you sync tabs and only after you change the device name leaving the tabs as they were.
Blocks: 1239084
I'd be very surprised if this is a regression as almost nothing has changed in the actual sync engine (other than bug 1246076, but I'd be surprised if that broke anything), so I'm marking as P1 for an investigation. CC Kit as this will be roughly similar to bug 1250531.
Priority: -- → P1
Blocks: 1254391
If we want to enable this feature for 47, SV team would like to see this fixed. Tracked as blocking for Fx47.
Indeed, I think this was fixed by bug 1250531. Adrian, could you please confirm?
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(adrian.florinescu)
Resolution: --- → DUPLICATE
Hey Kit. As far as I know, the sync servers have had issues lately; not entirely sure at this point if they are stable or not. As soon as the sync stabilizes, I will check this bug and clear the NI on me.
Flags: needinfo?(adrian.florinescu)
Flags: needinfo?(adrian.florinescu)
Thanks very much, Adrian. There's no rush; whenever the outage clears up and it's convenient for you.
48.0a1 20160410030224 Mozilla/5.0 (X11; Linux i686; rv:48.0) Gecko/20100101 Firefox/48.0 / Ubuntu 14.04
48.0a1 20160410030224 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:48.0) Gecko/20100101 Firefox/48.0 /OSX10.10

The problem is still reproducible. In case the device name does change the first time, redo the 4th step from the initial STR(without adding any new tabs or any other data to the sync).
Status: RESOLVED → REOPENED
Flags: needinfo?(adrian.florinescu) → needinfo?(kcambridge)
Resolution: DUPLICATE → ---
Ah, right! I'm sorry I missed that case. Should be a straightforward fix.
Flags: needinfo?(kcambridge)
Mark, I think this should do the trick. I can't test it out yet because FxA is blocking the MTV office, but this should be fixed soon.
Comment on attachment 8740083 [details]
MozReview Request: Bug 1254129 - Read the device name from the clients collection when fetching Synced Tabs. r?markh

https://reviewboard.mozilla.org/r/45545/#review42131
Attachment #8740083 - Flags: review?(markh) → review+
Hi Kit, Mark, did we forget to land this fix on Nightly? I was wondering if we can land this in Nightly today, get SV to validate the fix and then uplift to Beta (if deemed low risk) by Wednesday/Thursday? Thanks!
Flags: needinfo?(markh)
Flags: needinfo?(kcambridge)
Flags: firefox-backlog+
Oops, yes, this slipped off my radar because I didn't assign it to myself. Thanks, Ritu!
Assignee: nobody → kcambridge
Flags: needinfo?(markh)
Flags: needinfo?(kcambridge)
https://hg.mozilla.org/mozilla-central/rev/a653384e97eb
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Hello Adrian, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(adrian.florinescu)
(In reply to Kit Cambridge [:kitcambridge] from comment #13)
> Oops, yes, this slipped off my radar because I didn't assign it to myself.
> Thanks, Ritu!

Hi Kit, thanks for landing this in Nightly. Should we uplift to Beta47 and Aurora48 as well?
Flags: needinfo?(kcambridge)
Looks like a653384e97eb didn't make it in to today's Nightly, based on http://mcomella.xyz/is-it-in-nightly/. I'll fill out the uplift form now, though. Thanks!
Flags: needinfo?(kcambridge)
Comment on attachment 8740083 [details]
MozReview Request: Bug 1254129 - Read the device name from the clients collection when fetching Synced Tabs. r?markh

I think we should uplift to Aurora, but I'm less sure about Beta. This patch should apply cleanly, but I don't know if it'll fix the issue entirely, or if we need bug 1250531, too.

Approval Request Comment
[Feature/regressing bug #]: This bug.
[User impact if declined]: Device name changes in about:preferences#sync won't show up in the Synced Tabs panel or sidebar on other devices.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=c94c82ce2365
[Risks and why]: Low risk. This patch doesn't change client syncing semantics; only exposes data that's already available to Sync.
[String/UUID change made/needed]: None.
Attachment #8740083 - Flags: approval-mozilla-beta?
Attachment #8740083 - Flags: approval-mozilla-aurora?
Comment on attachment 8740083 [details]
MozReview Request: Bug 1254129 - Read the device name from the clients collection when fetching Synced Tabs. r?markh

SV deemed this is a blocking issue for Sync'd tabs sidebar feature, Aurora48+, Beta47+
Attachment #8740083 - Flags: approval-mozilla-beta?
Attachment #8740083 - Flags: approval-mozilla-beta+
Attachment #8740083 - Flags: approval-mozilla-aurora?
Attachment #8740083 - Flags: approval-mozilla-aurora+
has problems to apply to beta:

grafting 344352:584c4d11538d "Bug 1254129 - Read the device name from the clients collection when fetching Synced Tabs. r=markh, a=ritu"
merging services/sync/modules/SyncedTabs.jsm
merging services/sync/modules/engines/clients.js
merging services/sync/tests/unit/test_syncedtabs.js
warning: conflicts while merging services/sync/modules/engines/clients.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging services/sync/tests/unit/test_syncedtabs.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(kcambridge)
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 49.0a1 (buildID: 20160511030221).
Flags: needinfo?(adrian.florinescu)
Try push with rebase and modified test, since we're not uplifting bug 1250531: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0dd418fdadd
Flags: needinfo?(kcambridge)
Setting the flag for verification on 47.0b6.
Flags: qe-verify+
Verified fixed on Windows 7 64bit, Mac OS X 10.9.5 and Ubuntu 13.10 32bit using Firefox 47 Beta 6 (buildID: 20160516123243) and latest Aurora 48.0a2 (buildID: 20160519004038).
You need to log in before you can comment on or make changes to this bug.