1254169 - Migrate Keyboard to use L20n

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Keyboard is used by the TV, is maintained and is using deprecated l10n.js.

Let's migrate it to l20n

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1254169-migrate-keyboard-to-l20n > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8727558 [details] [review]
[gaia] zbraniecki:1254169-migrate-keyboard-to-l20n > mozilla-b2g:master

Tim, can you review this for me?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8727558 [details] [review]
[gaia] zbraniecki:1254169-migrate-keyboard-to-l20n > mozilla-b2g:master

Please remove the es6 syntax before merging, thanks!

It looks like we assume LayoutItemView#_getHumanFileSize is safe without run to completion -- the promise won't execute callback out-of-order, is it? If so, let's ignore it.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/799ed19d35df344271175531e56293bcd1edca4b

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Could you merge a follow-up commit and remove the use of arrow functions too (only in the code, not in the tests).

We want to avoid es6 for the same reason... thanks.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Oh, I wrote the patch, and somehow it didn't get to the branch before merging, sorry!

Landed: https://github.com/mozilla-b2g/gaia/commit/cee2b43ffff073399a7c5629cda2776b61ccbb6b