1254223 - [az] Azerdict search plugin icon missing

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Emin Mastizada]

Attachment: 128-128-azerdict-icon.svg

Azerdict icon is missing in search plugins. It results to a problem in search suggestions:
http://people.mozilla.org/~sarentz/fxios/screenshots/az/az/iPhone5s-Settings-4.png
http://people.mozilla.org/~sarentz/fxios/screenshots/az/screenshots.html

Comment 1

[Emin Mastizada]

http://people.mozilla.org/~sarentz/fxios/screenshots/az/az/iPhone5s-URLBar-02.png

Comment 2

[Francesco Lodolo [:flod]]

@emin
Is the searchplugin showing up fine on Android? I wonder if it's the empty line in the middle of the data URI.

https://github.com/mozilla/firefox-ios/blob/master/Client/Assets/Search/SearchPlugins/az/azerdict.xml#L8-L9

Comment 3

[Emin Mastizada]

@flod
It works fine on Android. Just checked base64 string, looks like correct (converting to image was successful). Wikipedia don't have that new line, most probably that is causing problem.

Comment 4

[Richard Newman [:rnewman]]

Fingers point to newline.

Comment 5

[Francesco Lodolo [:flod]]

Once confirmed I can port the change to Aurora, so it won't create issues in future syncs ios<->Android.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Confirming this is the newline in the <Image> tag. Removing the newline shows the correct icon.

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

v3.x https://github.com/mozilla/firefox-ios/commit/1b4f80c61efc4eec78e850ebbb62463db25076f4
master https://github.com/mozilla/firefox-ios/commit/49a49238d05319d0baa58219207b564cc1d8935b

:flod if you do this change in Android then we will pick it up next time we sync search engines.

Comment 8

[Francesco Lodolo [:flod]]

Done
https://hg.mozilla.org/releases/l10n/mozilla-beta/az/rev/4354c8c3ee5f
https://hg.mozilla.org/releases/l10n/mozilla-aurora/az/rev/4354c8c3ee5f