Closed
Bug 1254239
Opened 5 years ago
Closed 5 years ago
Align bookmark folders with other home panel items
Categories
(Firefox for Android :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 48
People
(Reporter: liuche, Assigned: liuche)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Screenshot: Aligned folder items
Next evolution step for bookmarks - instead of having a different alignment level from history items, everything should be aligned the same.
|
Assignee | |
Comment 1•5 years ago
|
||
Assignee: nobody → liuche
Attachment #8727551 -
Flags: feedback?(alam)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38503/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38503/
Attachment #8727552 -
Flags: review?(michael.l.comella)
Comment on attachment 8727552 [details] MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella https://reviewboard.mozilla.org/r/38503/#review35169
Attachment #8727552 -
Flags: review?(michael.l.comella) → review+
|
||
Comment 4•5 years ago
|
||
Comment on attachment 8727551 [details]
Screenshot: Aligned folder items
beautiful!
Attachment #8727551 -
Flags: feedback?(alam) → feedback+
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 8727552 [details] MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella Approval Request Comment [Feature/regressing bug #]: Home panels item styling [User impact if declined]: Alignment will be off for bookmark folders [Describe test coverage new/current, TreeHerder]: in Nightly [Risks and why]: very, very low - changing two dimensions [String/UUID change made/needed]: none
Attachment #8727552 -
Flags: approval-mozilla-aurora?
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/56b9ab351458
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
|
|
Assignee | |
Updated•5 years ago
|
Blocks: bookmark-folders
Comment on attachment 8727552 [details] MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella Seems like a simple change, taking it.
Attachment #8727552 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
|
||
Comment 9•5 years ago
|
||
| bugherderuplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/bacbce751fa7
|
||
Comment 10•4 years ago
|
||
Tested using: Device: Huawei Honor (Android 5.1.1) Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)
|
|
||
Updated•4 years ago
|
|
|
||
Comment 11•4 years ago
|
||
Since this is verified I'll mark it as verified fixed.
Status: RESOLVED → VERIFIED
|
||
Updated•2 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•