Closed Bug 1254239 Opened 8 years ago Closed 8 years ago

Align bookmark folders with other home panel items

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 verified, firefox48 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox47 --- verified
firefox48 --- verified

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(3 files)

Screenshot: Aligned folder items
86.34 KB, image/png
antlam
: feedback+
Details
MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella
58 bytes, text/x-review-board-request
mcomella
: review+
ritu
: approval-mozilla-aurora+
Details
Screenshot_2016-05-17-15-49-23.png
59.87 KB, image/png
Details 
Next evolution step for bookmarks - instead of having a different alignment level from history items, everything should be aligned the same.
Assignee: nobody → liuche

        Attachment #8727551 -
        Flags: feedback?(alam)

    
    

    
  
Comment on attachment 8727552 [details]
MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella

https://reviewboard.mozilla.org/r/38503/#review35169

        Attachment #8727552 -
        Flags: review?(michael.l.comella) → review+

    
    

    
  
Comment on attachment 8727551 [details]
Screenshot: Aligned folder items

beautiful!

        Attachment #8727551 -
        Flags: feedback?(alam) → feedback+

    
    

    
  
Comment on attachment 8727552 [details]
MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella

Approval Request Comment
[Feature/regressing bug #]: Home panels item styling
[User impact if declined]: Alignment will be off for bookmark folders
[Describe test coverage new/current, TreeHerder]: in Nightly
[Risks and why]: very, very low - changing two dimensions
[String/UUID change made/needed]: none

        Attachment #8727552 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/56b9ab351458
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox48:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

    
  
Blocks: bookmark-folders

    
    

    
  
Comment on attachment 8727552 [details]
MozReview Request: Bug 1254239 - Align bookmark folders with other home panel items. r=mcomella

Seems like a simple change, taking it.

        Attachment #8727552 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  


  
Tested using:
Device: Huawei Honor (Android 5.1.1)
Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)

    
    

    
  
Since this is verified I'll mark it as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.