Closed Bug 1254243 Opened 5 years ago Closed 5 years ago

Use SkPath::contains directly in PathSkia::ContainsPoint

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Right now PathSkia::ContainsPoint uses an ugly workaround involving converting the path to a region which is slow and imprecise. The original issue with SkPath::contains inclusivity was fixed upstream in Skia in December 2015. We already have the fix included in our tree as part of the Skia m49 update.

Upstream issue regarding fix: https://bugs.chromium.org/p/skia/issues/detail?id=4265
Did try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a749de0b5fe0

Seems to be clear. The R-e10s orange on OS X seems to be from some other pre-existing brokenness on central at the time I did a pull (visibly in Similar Jobs).
Attachment #8727554 - Flags: review?(matt.woodrow)
Attachment #8727554 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/f00750b51d8f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.