Closed
Bug 1254243
Opened 9 years ago
Closed 9 years ago
Use SkPath::contains directly in PathSkia::ContainsPoint
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
|
2.73 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Right now PathSkia::ContainsPoint uses an ugly workaround involving converting the path to a region which is slow and imprecise. The original issue with SkPath::contains inclusivity was fixed upstream in Skia in December 2015. We already have the fix included in our tree as part of the Skia m49 update.
Upstream issue regarding fix: https://bugs.chromium.org/p/skia/issues/detail?id=4265
|
Assignee | |
Comment 1•9 years ago
|
||
Did try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a749de0b5fe0
Seems to be clear. The R-e10s orange on OS X seems to be from some other pre-existing brokenness on central at the time I did a pull (visibly in Similar Jobs).
Attachment #8727554 -
Flags: review?(matt.woodrow)
|
||
Updated•9 years ago
|
Attachment #8727554 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•