Closed
Bug 1254275
Opened 8 years ago
Closed 8 years ago
Scroll snapping on OS X touchpads doesn't snap if the fingers are lifted without any momentum.
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
VERIFIED
FIXED
mozilla48
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: correctness, regression, Whiteboard: [gfx-noted])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
kats
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
STR: 1. Be on OS X with a touchpad or a magic mouse. 2. Load http://jsbin.com/pikusa/edit?html,css,output 3. Over the cat picture, scroll to the right until you're halfway between two cats, pause, and lift your fingers. Now the scroll box stays in the in-between state and doesn't snap. Snapping with momentum works fine.
Updated•8 years ago
|
Updated•8 years ago
|
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41621/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41621/
Attachment #8733175 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
Comment on attachment 8733175 [details] MozReview Request: Bug 1254275 - Inspect the event queue to find out whether momentum events are following. r?kats https://reviewboard.mozilla.org/r/41621/#review38153 ::: gfx/layers/apz/src/AsyncPanZoomController.cpp:2000 (Diff revision 1) > > SetState(NOTHING); > RequestContentRepaint(); > > + if (!aEvent.mFollowedByMomentum) { > + RequestSnapToDestination(); It's probably better to call RequestSnap() here, rather than RequestSnapToDestination(), since we aren't going to be doing an animation, and there's no need to compute the predicted destination.
Attachment #8733175 -
Flags: review?(bugmail.mozilla) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dc4afd0b7626
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8733175 [details] MozReview Request: Bug 1254275 - Inspect the event queue to find out whether momentum events are following. r?kats Approval Request Comment [Feature/regressing bug #]: APZ and possibly bug 1235994 [User impact if declined]: Unreliable scroll snapping with Mac touchpads [Describe test coverage new/current, TreeHerder]: no coverage for snapping in response to touchpad events [Risks and why]: low [String/UUID change made/needed]: none
Flags: needinfo?(mstange)
Attachment #8733175 -
Flags: approval-mozilla-aurora?
Comment on attachment 8733175 [details] MozReview Request: Bug 1254275 - Inspect the event queue to find out whether momentum events are following. r?kats APZ related, Aurora47+
Attachment #8733175 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/4265845fa347
Comment 10•8 years ago
|
||
Verified as fixed un\sing Firefox 47 beta 6 and latest Aurora 48.0a2 under Mac OS X 10.9.5 retina with touchpad.
You need to log in
before you can comment on or make changes to this bug.
Description
•