Closed Bug 1254287 Opened 5 years ago Closed 5 years ago

Remove the Engineering Mode API

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: fabrice, Assigned: gsvelto)

References

Details

Attachments

(1 file, 2 obsolete files)

[PATCH v2] Remove the EngineeringMode API
22.55 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
Keeping the permission is ok, but everything that is gated by AvailableIn=CertifiedApps needs to be chrome only instead.

http://mxr.mozilla.org/mozilla-central/source/dom/webidl/EngineeringMode.webidl#7
No longer blocks: 1252143
I was considering removing the engineering mode API altogether. I don't think we'll ever use it anymore and it's a pretty trivial task to remove it (a few line changes in gaia and basically two patches to revert in gecko). This could be done directly in mozilla-central. Thoughts about this? Do we still need it for something else?
Flags: needinfo?(fabrice)
Flags: needinfo?(ehung)
It's fine to remove it; I believe no one uses it.
Flags: needinfo?(ehung)
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
This patch removes the EngineeringMode API and changes the affected tests and components to reflect the removal.
Flags: needinfo?(fabrice)
Attachment #8740095 - Flags: review?(ehung)
Hi Gabriele,
Sorry for my late reply, but I'm afraid that you attached a wrong patch?
Attachment #8740095 - Flags: review?(ehung)
Yes, I attached the wrong one, sorry. Here's the correct patch.
Attachment #8740095 - Attachment is obsolete: true
Attachment #8743164 - Flags: review?(ehung)