Closed
Bug 1254287
Opened 5 years ago
Closed 5 years ago
Remove the Engineering Mode API
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: fabrice, Assigned: gsvelto)
References
Details
Attachments
(1 file, 2 obsolete files)
22.55 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Keeping the permission is ok, but everything that is gated by AvailableIn=CertifiedApps needs to be chrome only instead. http://mxr.mozilla.org/mozilla-central/source/dom/webidl/EngineeringMode.webidl#7
Assignee | ||
Comment 1•5 years ago
|
||
I was considering removing the engineering mode API altogether. I don't think we'll ever use it anymore and it's a pretty trivial task to remove it (a few line changes in gaia and basically two patches to revert in gecko). This could be done directly in mozilla-central. Thoughts about this? Do we still need it for something else?
Flags: needinfo?(fabrice)
Flags: needinfo?(ehung)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•5 years ago
|
||
This patch removes the EngineeringMode API and changes the affected tests and components to reflect the removal.
Flags: needinfo?(fabrice)
Attachment #8740095 -
Flags: review?(ehung)
Comment 4•5 years ago
|
||
Hi Gabriele, Sorry for my late reply, but I'm afraid that you attached a wrong patch?
Updated•5 years ago
|
Attachment #8740095 -
Flags: review?(ehung)
Assignee | ||
Comment 5•5 years ago
|
||
Yes, I attached the wrong one, sorry. Here's the correct patch.
Attachment #8740095 -
Attachment is obsolete: true
Attachment #8743164 -
Flags: review?(ehung)
Description
•